[MDL-74576] Don't hard fail on custom scopes in ags_info - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 4.0.1
Component/s: LTI provider
Labels:
- ci
- hqteam_alpha
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Epic Link:
Moodle 4.0.1 prioritised issues
Pull from Repository:
https://github.com/snake/moodle.git
Pull 4.0 Branch:
~~MDL-74576~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/8b359ad7a63...snake:MDL-74576-400
Pull Master Branch:
~~MDL-74576~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/1a744030d6...snake:MDL-74576-master
Workaround:

Hide

Remove those scopes which can't be recognized by Moodle (via the configuration of the LTI API key in Canvas - other LMS methods may vary) or comment out the exception in ags_info::validate_scopes() allowing the method to continue to set the known+supported scopes.

Show
Remove those scopes which can't be recognized by Moodle (via the configuration of the LTI API key in Canvas - other LMS methods may vary) or comment out the exception in ags_info::validate_scopes() allowing the method to continue to set the known+supported scopes.
Testing Instructions:

Hide

CiBot

Show
CiBot

Story Points:
1
Sprint:
4.1 holding pattern

Description

Reported as a potential problem in https://moodle.org/mod/forum/discuss.php?d=433941

Instead of hard failing with an exception in such cases, we should permit the launch. We'll check the appropriate scopes (those we know about) later anyway (where they're used).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Screenshot 2022-04-28 at 14.35.53.png
498 kB
28/Apr/22 9:16 PM
Screenshot 2022-04-28 at 14.36.10.png
343 kB
28/Apr/22 9:16 PM

Activity

People

Assignee:: Jake Dallimore

Reporter:: Jake Dallimore

Peer reviewer:: Mathew May

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Jake Dallimore, Jun Pataleta, Mathew May, Mathieu Pelletier

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 27/Apr/22 12:17 PM

Updated:: 06/May/22 10:36 PM

Resolved:: 06/May/22 10:36 PM

Fix Release Date:: 9/May/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 35m