Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.11.6, 4.0
-
1
-
4.1 holding pattern, 4.1 holding pattern 2
Description
The scenario which I reproduced in my instance while I was testing on MDL-73736 (jaked found this issue and I verified it on my instance):
Steps to replicate:
- In the config.php, add $CFG->disablelogintoken = true;
- Create a user say testuser1
- Try to log in with testuser1 with the incorrect password. Repeat it multiple times. You should see 'login_failed_count_since_success' incrementing.
- Now try to log in as testuser1 with the correct credentials.
- Now you should see that the 'login_failed_count_since_success' value in the database is not reset to zero. This is not correct.
On the other hand, if the user tries to set 'displayloginfailures' (in System Administration > Security > Notifications) to true (by ticking the check box and saving changes). Later when the user logs in with correct credentials, the 'login_failed_count_since_success' is reset to 0.