[MDL-74596] Add a new option to hide search bar in admin pages - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0.1
Fix Version/s: 4.1
Component/s: Administration, Navigation, UX
Labels:

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_401_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle.git
Pull 4.0 Branch:
~~MDL-74596~~-400
Pull 4.0 Diff URL:
https://github.com/marinaglancy/moodle/compare/bab7bdc53e...MDL-74596-400
Pull Main Branch:
~~MDL-74596~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/9ccda59e00...MDL-74596-master

Testing Instructions:

Hide

Login as admin
Go to Site administration>Users>Browse users
Make sure you can see a site administration search bar in the top right corner
Go to Site administration>Appearance>Default dashboard page
Make sure you can NOT see a site administration search bar

Modify the source code of admin/user.php and make the following change:

--- a/admin/user.php

+++ b/admin/user.php

@@ -21,7 +21,7 @@

     $unlock       = optional_param('unlock', 0, PARAM_INT);

     $resendemail  = optional_param('resendemail', 0, PARAM_INT);

-    admin_externalpage_setup('editusers');

+    admin_externalpage_setup('editusers', '', null, '', ['nosearch' => true]);

     $sitecontext = context_system::instance();

     $site = get_site();

Return to the "Site administration>Users>Browse users" page, make sure the search bar is no longer displayed

Show

Login as admin Go to Site administration>Users>Browse users Make sure you can see a site administration search bar in the top right corner Go to Site administration>Appearance>Default dashboard page Make sure you can NOT see a site administration search bar Modify the source code of admin/user.php and make the following change: --- a/admin/user.php +++ b/admin/user.php @@ -21,7 +21,7 @@ $unlock = optional_param('unlock', 0, PARAM_INT); $resendemail = optional_param('resendemail', 0, PARAM_INT); - admin_externalpage_setup('editusers'); + admin_externalpage_setup('editusers', '', null, '', ['nosearch' => true]); $sitecontext = context_system::instance(); $site = get_site(); Return to the "Site administration>Users>Browse users" page, make sure the search bar is no longer displayed

Description

Will be nice to have a new option ('hidesearchbar' or something similar) passed to admin_externalpage_setup function to avoid adding the searchbar as header action in some cases.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

1_MDL-74596_master.png
06/Jul/22 1:42 PM
17 kB
John Edward Pedregosa
2_MDL-74596_master.png
06/Jul/22 1:42 PM
31 kB
John Edward Pedregosa
3_MDL-74596_master.png
06/Jul/22 1:42 PM
15 kB
John Edward Pedregosa
confusing_search.png
31/May/22 10:08 PM
103 kB
Marina Glancy
no_search_bar_on_default_dashboard_page.png
07/Jun/22 7:52 PM
87 kB
Marina Glancy
Screenshot 2022-06-03 at 09.45.04.png
03/Jun/22 3:48 PM
991 kB
Rafael Lechugo
Screenshot 2022-06-03 at 09.48.37.png
03/Jun/22 3:48 PM
1.10 MB
Rafael Lechugo
search_bar_on_default_dashboard.png
07/Jun/22 7:50 PM
90 kB
Marina Glancy

Issue Links

has been marked as being related by

MDL-74026 Moodle 4 Admin pages should ALL have the admin search box

Closed

Activity

People

Assignee:: Marina Glancy

Reporter:: Mikel Martín Corrales

Peer reviewer:: Mikel Martín Corrales

Integrator:: Jun Pataleta

Tester:: John Edward Pedregosa

Participants:: Andrew Lyons, Barbara Ramiro, CiBoT, Jake Dallimore, John Edward Pedregosa, Jun Pataleta, Marina Glancy, Mikel Martín Corrales, Rafael Lechugo

Votes:: 2 Vote for this issue

Watchers:: 12 Start watching this issue

Dates

Created:: 28/Apr/22 6:12 PM

Updated:: 13/Feb/23 3:56 PM

Resolved:: 07/Jul/22 10:26 PM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 15m