Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74602

Page activity header missing from pages using the 'embedded' page layout

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74602-400
    • MDL-74602-master
    • Hide

      LTI Student Launch

      1. Set up two sites - call them tool and platform
      2. In the tool site, enable frame embedding (via Site admin)
      3. In the tool site, enable the auth_lti and enrol_lti plugins.
      4. In BOTH sites, disable any http security blocked hosts for both sites (so localhost calls are permitted).
      5. In the tool site, create a course "Tool course" with an assignment "Tool assignment"
      6. From course home, go to "More > Publish as LTI tools"
      7. Publish the assignment over LTI Advantage (click to add instance and select the assignment)
      8. Copy the "Custom properties" text and store it in a text file for later (it will be something like "id=xxxxxxx")
      9. In the tool site, go to Site admin > Plugins >  Enrolments > Publish as LTI tool > Tool registration
      10. Create a new registration, naming it "Platform site test"
      11. When presented with the endpoint URLs, copy the "Registration URL' to clipboard
      12. Now, log in to the platform site as admin
      13. Go to Site admin > Plugins > External tool > Manage tools
      14. Paste the Registration URL into the text field and click "Add LTI Advantage"
      15. When the tool card is displayed after page reload, click "Activate" to activate it.
      16. Now, create a new course with "Enable Completion tracking" set to "No"
      17. Enrol a student s1 in the course
      18. Click to add an activity and select "External tool"
      19. Set a name like "Assignment test"
      20. From the pre-configured tools list, select  the tool you created earlier
      21. Click "Show more"
      22. In the "Custom parameters" field, paste in the 'id=xxxx' custom property you recorded in the text file earlier
      23. Save the external tool instance
      24. Log out
      25. Log in to the platform site as a student
      26. Launch the external tool instance "Assignment test"
      27. Verify you see "Mark as done" on the page, along with opened and due date and that it sits above the "Add submission" button.
      28. Verify you don't see the assignment name "Tool assignment"

      Other activity pages

      1. In a new site, create a course
      2. Create the following modules:
        • Assignment
        • Book, along with on chapter.
        • Chat
        • SCORM (you can just use the attached sco)
        • Wiki, along with the first page entry
      3. View the assignment and click "Grade" to open the grader pane
      4. Verify you don't see "Mark as done" in the top left corner
      5. Open the chat and join the session
      6. Open browser dev tools (F12)
      7. Search the DOM for "Mark as done" and Verify no results are found
      8. Close dev tools
      9. Open the book module
      10. Print the book
      11. Verify you don't see "Mark as done" on the print view.
      12. Open the wiki module
      13. Print a wiki entry
      14. Verify you don't see "Mark as done" on the print view.
      15. Go to course home and note the course id
      16. Now, open dev tools and inspect the DOM
      17. Search for sesskey and find the link to logout.php?sesskey=XXXXX
      18. Copy the value of sesskey, i.e. the "XXXX" part.
      19. Now visit the following URL, substituting YOURSITE with the relevant prefix, X with your course ID and Y with your sesskey value

        YOURSITE/mod/lti/return.php?course=X&sesskey=Y&lti_errormsg=test&launch_container=2
        

      20. Verify:
        • You see a page that displays "An error occurred when launching the external tool: test"
        • You don't see "Mark as done" on the page.
      21. Open the SCORM activity and click "Enter" to start the player
      22. Verify you don't see "Mark as done" on the page.
      Show
      LTI Student Launch Set up two sites - call them tool and platform In the tool site, enable frame embedding (via Site admin) In the tool site, enable the auth_lti and enrol_lti plugins. In BOTH sites, disable any http security blocked hosts for both sites (so localhost calls are permitted). In the tool site, create a course "Tool course" with an assignment "Tool assignment" From course home, go to "More > Publish as LTI tools" Publish the assignment over LTI Advantage (click to add instance and select the assignment) Copy the "Custom properties" text and store it in a text file for later (it will be something like "id=xxxxxxx") In the tool site, go to Site admin > Plugins >  Enrolments > Publish as LTI tool > Tool registration Create a new registration, naming it "Platform site test" When presented with the endpoint URLs, copy the "Registration URL' to clipboard Now, log in to the platform site as admin Go to Site admin > Plugins > External tool > Manage tools Paste the Registration URL into the text field and click "Add LTI Advantage" When the tool card is displayed after page reload, click "Activate" to activate it. Now, create a new course with "Enable Completion tracking" set to "No" Enrol a student s1 in the course Click to add an activity and select "External tool" Set a name like "Assignment test" From the pre-configured tools list, select  the tool you created earlier Click "Show more" In the "Custom parameters" field, paste in the 'id=xxxx' custom property you recorded in the text file earlier Save the external tool instance Log out Log in to the platform site as a student Launch the external tool instance "Assignment test" Verify you see "Mark as done" on the page, along with opened and due date and that it sits above the "Add submission" button. Verify you don't see the assignment name "Tool assignment" Other activity pages In a new site, create a course Create the following modules: Assignment Book, along with on chapter. Chat SCORM (you can just use the attached sco) Wiki, along with the first page entry View the assignment and click "Grade" to open the grader pane Verify you don't see "Mark as done" in the top left corner Open the chat and join the session Open browser dev tools (F12) Search the DOM for "Mark as done" and Verify no results are found Close dev tools Open the book module Print the book Verify you don't see "Mark as done" on the print view. Open the wiki module Print a wiki entry Verify you don't see "Mark as done" on the print view. Go to course home and note the course id Now, open dev tools and inspect the DOM Search for sesskey and find the link to logout.php?sesskey=XXXXX Copy the value of sesskey, i.e. the "XXXX" part. Now visit the following URL, substituting YOURSITE with the relevant prefix, X with your course ID and Y with your sesskey value YOURSITE/mod/lti/return.php?course=X&sesskey=Y&lti_errormsg=test&launch_container=2 Verify : You see a page that displays "An error occurred when launching the external tool: test" You don't see "Mark as done" on the page. Open the SCORM activity and click "Enter" to start the player Verify you don't see "Mark as done" on the page.
    • 5
    • 4.1 holding pattern

    Description

      Problem

      This can be seen clearly in an LTI launch. Students launching into Moodle activities via LTI (from some other LMS, or another Moodle) no longer see the "Mark as done" manual completion controls above the activity.

      If the LTI instance (the specific enrolment instance for that activity in the tool site) has been set up to only sync grades when activities are complete, then no grades will be synced for any activities which are set to use manual completion by the student - the student has no way to complete these any more. This only affects the manual completion method but it nonetheless a problem we've introduced in 4.0.

      To see this is quite simple:
      See docs here: https://docs.moodle.org/400/en/Publish_as_LTI_tool

      1. Set up two Moodle 4.0 sites - tool and platform
      2. Setup the tool site accordingly (enable frame embedding and the two necessary plugins as per the docs above)
      3. Disable any http security blocked hosts for both sites (so localhost calls are permitted)
      4. Publish an assignment in the tool site (LTI 1.1 or 1.3 - it doesn't matter)
      5. Create the links to the content in the platform course (method varies - see External Tool docs for more information). Make sure the launch container is set to 'default' (which will embed via an iframe).
      6. Launch the published content in the platform site as a student.
        Expected: You see "Mark as done" inside the embedded iframe
        Actual: No such controls are present.

      Some examples - the red outline denotes the LTI frame.

      Here's what you want to see (3.11):

      Here's what you do see:

       

      Proposal

      I think the activity completion controls + any other dates, etc. which were included in the frame in 3.11 and beyond should also be included in the embedded view in 4.0. Perhaps view changes to the relevant pagelayout (LTI launches of this type use the 'embedded' layout).

      Attachments

        Activity

          People

            jaked Jake Dallimore
            jaked Jake Dallimore
            Laurent David Laurent David
            Ilya Tregubov Ilya Tregubov
            Carlos Escobedo Carlos Escobedo
            Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/May/22

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 13 minutes
                1d 2h 13m