Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74675

Preserve column type in group concatenation callback methods

XMLWordPrintable

      See this comment from formats helper:

      • Note that type hints for each $value argument are avoided to allow for these callbacks to be executed when columns are
      • aggregated using one of the "Group concatenation" methods, where the value is typically stringified

      This is easy to miss when implementing column callback methods, and causes PHP to throw TypeErrors. We should fix this, to ensure the original type of the column is preserved when passing values to it's callbacks during group concatenation aggregation

      For context, see this change from MDL-72663 where type hinting was removed from existing callbacks (we should revert that part if possible)

      This would be nice to correct now, as we are starting to add new report sources for 4.1 (MDL-73987)

            pholden Paul Holden
            pholden Paul Holden
            David Carrillo David Carrillo
            Shamim Rezaie Shamim Rezaie
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 5 minutes
                2h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.