Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74756

Previous activity with completion not working if activity completion is disabled

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-74756-MOODLE_311_STABLE
    • MDL-74756-MOODLE_400_STABLE
    • MDL-74756-MOODLE_401_STABLE
    • MDL-74756-master
    • Hide
      1. Create course.
      2. As teacher create two labels: label1, label2 (I think we now call it 'Text and media area' activity)
      3. label2 has to be directly below label1
      4. Edit settings for label1
        • In the "Activity completion" section, set completion tracking to "Students can manually mark this activity as completed".
      5. Edit settings for label2
        • In the "Restrict access" section, add an "Activity completion" restriction and select "Previous activity with completion" and "must be marked complete" from the newly added dropdowns.
        • Click on the eye (so that it's displayed as crossed out) before the newly added condition.
        • In the "Activity completion" section, set completion tracking to "Do not indicate Activity completion".
      6. Enrol a student in this course
      7. Log in as the student and go to the course.
      8. Mark label1 as completed.
      9. Verify that label2 is now fully visible.
      Show
      Create course. As teacher create two labels: label1, label2 (I think we now call it 'Text and media area' activity) label2 has to be directly below label1 Edit settings for label1 In the "Activity completion" section, set completion tracking to "Students can manually mark this activity as completed". Edit settings for label2 In the "Restrict access" section, add an "Activity completion" restriction and select "Previous activity with completion" and "must be marked complete" from the newly added dropdowns. Click on the eye (so that it's displayed as crossed out) before the newly added condition. In the "Activity completion" section, set completion tracking to "Do not indicate Activity completion". Enrol a student in this course Log in as the student and go to the course. Mark label1 as completed. Verify that label2 is now fully visible.

    Description

      Restricting access to a course module by using "activity completion" and "Previous activity with completion" does not work, when activity completion of current module is disabled.

      Steps to reproduce:

      1. Create course.
      2. As teacher create two activites, for example assignments (also tested with labels, seems to not depend on type of activity): assignment1, assignment2
      3. assignment2 has to be directly below assignment1
      4. assignment1: "Activity completion" -> "Students can manually mark this activity as completed"
      5. assignment2: "Restrict access" -> "Activity completion" -> "Previous activity with completion"
      6. Now the important part: assignment2 -> "Activity completion" -> "Do not indicate Activity completion"
      7. Enrol a student in this course
      8. Log in as student of this course. Mark assignment1 as completed. You will not have access to assignment2 -> Bug!

      This does not happen, if you explicitely specify assignment1 as dependency for assignment2, it only happens if you use "Previous activity with completion".

      Another strange thing:

      If you mark activity1 as "completed" not as student, but by switching role from teacher to student and then change back to your teacher role, you will see activity2 labeled with "Not available unless: The activity (Missing activity) is marked complete (hidden otherwise)" -> this also should not happen.

      Tested this on 4.0.1 as well as 3.11.6, versions 3.11.7 and previous versions probably also affected.

      Attachments

        Activity

          People

            stefan.hanauska Stefan Hanauska
            phmemmel PhMemmel
            Shamim Rezaie Shamim Rezaie
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            7 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Mar/23

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 20 minutes
                2h 20m