[MDL-74802] Notification close button does not have meaningful label - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.11.7
Fix Version/s: 3.11.8, 4.0.2
Component/s: Accessibility
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Epic Link:
Moodle 4.0 Accessibility Audit
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 3.11 Branch:
~~MDL-74802~~-311-2
Pull 3.11 Diff URL:
https://github.com/junpataleta/moodle/compare/2affa30359...MDL-74802-311-2
Pull 4.0 Branch:
~~MDL-74802~~-400-2
Pull 4.0 Diff URL:
https://github.com/junpataleta/moodle/compare/d237a6312f...MDL-74802-400-2
Pull Master Branch:
~~MDL-74802~~-master-2
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/6c114e2a80...MDL-74802-master-2
Testing Instructions:
Hide

Enable developer mode

Go to Site administration > Development > Template library

Search for notification

Check the x button on the notification_xx templates on the accessibility tree

Confirm that it is labelled as "Dismiss this notification"

Using a screen reader (e.g. NVDA), tab to the x button.

Confirm that the alert message is being read first and then the button gets read out as "Dismiss this notification"
Show
Enable developer mode Go to Site administration > Development > Template library Search for notification Check the x button on the notification_xx templates on the accessibility tree Confirm that it is labelled as "Dismiss this notification" Using a screen reader (e.g. NVDA), tab to the x button. Confirm that the alert message is being read first and then the button gets read out as "Dismiss this notification"

Description

To quickly check:

Enable developer mode
Go to Site administration > Development > Template library
Search for notification
Check the x button on the notification_xx templates on the accessibility tree / via the screen reader
Expected: It should have a meaningful label
Actual: There's no meaningful label.

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-74802_master.mp4
1.26 MB
09/Jun/22 9:32 AM
MDL-74802_v311.mp4
952 kB
09/Jun/22 9:32 AM
MDL-74802_v400.mp4
1.14 MB
09/Jun/22 9:32 AM
MDL-74802 tooltip.png
9 kB
23/May/22 8:08 AM

Issue Links

caused a regression

MDL-75055 Notification alert close button is misaligned

Closed

Activity

People

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Simey Lameze

Integrator:: Sara Arjona (@sarjona)

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Ilya Tregubov, Jun Pataleta, Sara Arjona (@sarjona), Simey Lameze

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 19/May/22 10:21 PM

Updated:: 07/Jul/22 1:39 PM

Resolved:: 10/Jun/22 11:46 PM

Fix Release Date:: 11/Jul/22

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

3h 46m