Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74815

Colour contrast issues on the site homepage

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-74815-master
    • Hide
      Prerequisite
      1. Another test site with the same version you're testing that does not have the patch.
      Setup
      1. Download the test script to your moodle root folder:
      2. Download the list of changed SVG files to your root folder:
      3. Edit the test script and change "$beforesite" with the value pointing to your test site that does not have the patch. e.g. if you're testing on 311 and you have the unpatched 311 version on "localhost/stable_311":

        $beforesite = 'http://localhost/stable_311/';
        

        Note: Trailing slash important!

      Test
      1. Open the test script on your browser
      2. Confirm that all icons listed are of grey colour.
      3. Compare the SVG icons before and after the patch:
      4. Confirm that the icons after the patch are a bit darker than before.
      5. Inspect one of the SVG icons after the patch using your browser dev tools
      6. Confirm that the SVG icon after the patch has a fill colour of #888.
      7. Confirm that the SVG icons after the patch are the same size as those before.
      8. Check the PNG files
      9. Confirm that the PNG files after the patch are a little darker than before.
      10. Confirm that the PNG files after the patch are roughly the same size as those before the patch.
      Show
      Prerequisite Another test site with the same version you're testing that does not have the patch. Setup Download the test script to your moodle root folder: master and 400: svgtest.php 311: svgtest_311.php Download the list of changed SVG files to your root folder: master and 400: changed.txt 311: changed_311.txt Edit the test script and change " $beforesite " with the value pointing to your test site that does not have the patch. e.g. if you're testing on 311 and you have the unpatched 311 version on " localhost/stable_311 ": $beforesite = 'http://localhost/stable_311/'; Note: Trailing slash important! Test Open the test script on your browser Confirm that all icons listed are of grey colour. Compare the SVG icons before and after the patch: Confirm that the icons after the patch are a bit darker than before. Inspect one of the SVG icons after the patch using your browser dev tools Confirm that the SVG icon after the patch has a fill colour of #888. Confirm that the SVG icons after the patch are the same size as those before. Check the PNG files Confirm that the PNG files after the patch are a little darker than before. Confirm that the PNG files after the patch are roughly the same size as those before the patch.
    • 1
    • HQ Team International CIH2-226

    Description

      1. Log in as an admin
      2. Create some courses under a couple of categories
      3. Edit the frontpage
      4. Add Combo List
      5. The expand/collapse arrows icons and course icons don't have sufficient colour contrast against the white background (#999 vs #FFF results in a 2.8:1 contrast ratio which does not meet the required 3:1 contrast ratio for Level AA)

      Attachments

        1. changed_311.txt
          8 kB
        2. changed.txt
          8 kB
        3. CourseCategoriesAfter-Before.png
          CourseCategoriesAfter-Before.png
          84 kB
        4. CourseList and Available Courses After-Before.png
          CourseList and Available Courses After-Before.png
          405 kB
        5. home.png
          home.png
          14 kB
        6. MDL-74815 css.png
          MDL-74815 css.png
          15 kB
        7. MDL-74815 data registry expand collapse .png
          MDL-74815 data registry expand collapse .png
          23 kB
        8. MDL-74815 manage categories page.png
          MDL-74815 manage categories page.png
          42 kB
        9. MDL-74815 rtl.png
          MDL-74815 rtl.png
          8 kB
        10. MDL-74815 site home.png
          MDL-74815 site home.png
          12 kB
        11. patched_2_MDL-74815_master.png
          patched_2_MDL-74815_master.png
          25 kB
        12. patched_2_MDL-74815_v311.png
          patched_2_MDL-74815_v311.png
          27 kB
        13. patched_2_MDL-74815_v400.png
          patched_2_MDL-74815_v400.png
          26 kB
        14. patched_MDL-74815_master.png
          patched_MDL-74815_master.png
          57 kB
        15. patched_MDL-74815_v311.png
          patched_MDL-74815_v311.png
          52 kB
        16. patched_MDL-74815_v400.png
          patched_MDL-74815_v400.png
          57 kB
        17. screenshot-1.png
          screenshot-1.png
          11 kB
        18. svgtest_311.php
          2 kB
        19. svgtest.php
          2 kB
        20. unpatched_MDL-74815_master.png
          unpatched_MDL-74815_master.png
          56 kB
        21. unpatched_MDL-74815_v311.png
          unpatched_MDL-74815_v311.png
          60 kB
        22. unpatched_MDL-74815_v400.png
          unpatched_MDL-74815_v400.png
          51 kB

        Activity

          People

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Stevani Andolo Stevani Andolo
            Jake Dallimore Jake Dallimore
            John Edward Pedregosa John Edward Pedregosa
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 5 hours, 43 minutes
                1w 5h 43m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.