Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74866

iCalendar DESCRIPTION not imported when there is an ALTREP

    XMLWordPrintable

Details

    • MOODLE_311_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-74866-master
    • Hide

      Covered by newly created Behat. Manual steps are below

      Steps to test

      1. Login as admin.
      2. Open the user profile menu.
      3. Click on the calendar and further click on 'Import or export calendars' link.
      4. Click on 'Import calendar' button. User would land at 'Import calendar'  page.
      5. Set Calendar name to: Test ICS
      6. Set Import from to: Calendar file
      7. Select the Timetable-Lecture.ics  file.
      8. Press the 'Import calendar' button.
      9. Open the user profile menu.
      10. Click on Calendar.
      11. Navigate to May 2022.
      12. Click on the 27th of May 2022 to view that day's detail.
      13. User should see 2 events: Concurrency and Introduction to Formal Proof.
      14. Observe the description of both events.
      Show
      Covered by newly created Behat. Manual steps are below Steps to test Login as admin. Open the user profile menu. Click on the calendar and further click on 'Import or export calendars' link. Click on 'Import calendar' button. User would land at 'Import calendar'  page. Set Calendar name to: Test ICS Set Import from to: Calendar file Select the Timetable-Lecture.ics   file. Press the 'Import calendar' button. Open the user profile menu. Click on Calendar. Navigate to May 2022. Click on the 27th of May 2022 to view that day's detail. User should see 2 events: Concurrency and Introduction to Formal Proof. Observe the description of both events.
    • 1
    • Team Hedgehog 4.1 sprint 0.1, Team Hedgehog 4.1 sprint 0.2

    Description

      Steps to replicate

      1. Login as admin.
      2. Open the user profile menu.
      3. Click on Calendar.
      4. Click on the Import or export calendars link.
      5. Click on the Import calendar button.
      6. Set the Calendar name to: Test ICS.
      7. Set the Import from to: Calendar file.
      8. Select the Timetable-Lecture.ics file.
      9. Press the Import calendar button.
      10. Open the user profile menu.
      11. Click on Calendar.
      12. Navigate to May 2022.
      13. Click on the 27th of May 2022 to view that day's detail.
      14. Verify that you will see 2 events: Concurrency and Introduction to Formal Proof.
      15. Observe the description of both events.

      Expected result:

      1. Description of Concurrency event is: Concurrency, A lecturer http://some.alternative.representation/
      2. Description of Introduction to Formal Proof event is: Introduction to Formal Proof, A lecturer http://some.alternative.representation/

      Actual result:

      1. The Concurrency event does not have a description.

       

      If an iCalendar .ics has a DESCRIPTION property and that has an ALTREP parameter, the description may not import and is not shown in the calendar/view.php

      https://datatracker.ietf.org/doc/html/rfc5545#section-3.2.1

      e.g. this imports:

      DESCRIPTION:Introduction to Formal Proof\, A lecturer

      this does not:

      DESCRIPTION;ALTREP="http://some.alternative.representation/":Concurrency\, A lecturer

      Looking at the regex in https://gitit.nmu.edu/clewis/moodle/-/blob/v2.8.0/lib/bennu/iCalendar_components.php#L246 and putting that into https://regex101.com/

      it parses.

       

      The expected behaviour is that both descriptions show.

       

      Attachments

        Activity

          People

            huongn@moodle.com Huong Nguyen
            enc Edward Crichton
            Sujith Haridasan Sujith Haridasan
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 5 hours, 33 minutes
                3d 5h 33m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.