Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74869

New Icon colors should be SCSS variables so they are easy to override.

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 4.0.1
    • None
    • None
    • MOODLE_400_STABLE

    Description

      The new color coding for activity icon types is neat.

      It would be simpler to override if they were set as variables with default values first and then added to the array.

      Then you'd just need to set the variable. See the way bootstrap sets its basic colors before adding them to their array for an example.

       

      $activity-icon-colors: () !default;
      $activity-icon-colors: map-merge(
          (
              "administration": #5d63f6,
              "assessment": #eb66a2,
              "collaboration": #f7634d,
              "communication": #11a676,
              "content": #399be2,
              "interface": #a378ff
          ),
          $activity-icon-colors
      );
      

      vs

      $primary:       $blue !default;
      $secondary:     $gray-600 !default;
      $success:       $green !default;
      $info:          $cyan !default;
      $warning:       $yellow !default;
      $danger:        $red !default;
      $light:         $gray-100 !default;
      $dark:          $gray-800 !default;$theme-colors: () !default;
      $theme-colors: map-merge(
        (
          "primary":    $primary,
          "secondary":  $secondary,
          "success":    $success,
          "info":       $info,
          "warning":    $warning,
          "danger":     $danger,
          "light":      $light,
          "dark":       $dark
        ),
        $theme-colors
      );
        

      Attachments

        Activity

          People

            Unassigned Unassigned
            bawjaws David Scotson
            Amy Groshek, David Scotson, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: