Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74870

All the SCSS settings that can't be overriden by SCSS

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 4.0.1
    • None
    • None
    • MOODLE_400_STABLE

    Description

      There's several SCSS settings used in the Boost theme.

      Many of them do not use the !default setting, which means they are fixed, and cannot be overriden by a preset.

      Here is a script to show them, and the current list from a recent 4.0 version:

      cd theme/boost/scss
      grep '^\s*\$.*:.*;' {.,moodle,preset}/*.scss | grep -v '!default'

      moodle/blocks.scss:$blocks-plus-gutter: $blocks-column-width + ( $grid-gutter-width / 2 );
      moodle/blocks.scss:$card-gutter : $card-deck-margin * 2;
      moodle/calendar.scss:$calendarCurrentDateColor: $white;
      moodle/calendar.scss:$calendarCurrentDateBackground: $primary;
      moodle/core.scss:    $mod-indent-size: 30px;
      moodle/core.scss:        $width: ($i * $mod-indent-size);
      moodle/core.scss:    $pageHeaderHeight: 140px;
      moodle/core.scss:$scrollbar-thumb: $primary;
      moodle/core.scss:$scrollbar-track: lighten($primary, 40%);
      moodle/course.scss:$activity-item-color: $body-color;
      moodle/courseindex.scss:$courseindex-item-padding-y: 0.5rem;
      moodle/courseindex.scss:$courseindex-item-padding-x: 0.5rem;
      moodle/drawer.scss:$fixed-header-y: $navbar-height;
      moodle/drawer.scss:$right-drawer-width: 320px;
      moodle/grade.scss:            $rubricPadding: 6px;
      moodle/icons.scss:$icon-width: 16px;
      moodle/icons.scss:$icon-height: 16px;
      moodle/icons.scss:$icon-big-width: 64px;
      moodle/icons.scss:$icon-big-height: 64px;
      moodle/modules.scss:$author-image-width: 70px;
      moodle/modules.scss:$author-image-margin: 24px;
      moodle/modules.scss:$author-image-width-sm: 30px;
      moodle/modules.scss:$author-image-margin-sm: 8px;
      moodle/modules.scss:        $bg: lighten($red, ($i * 3%));
      moodle/modules.scss:$popout-header-font-size: 1.5 * $font-size-base;
      moodle/modules.scss:$popout-header-height: 4rem;
      moodle/popover-region.scss:$standard-border: 1px solid #ddd;
      moodle/popover-region.scss:$region-container-height: 500px;
      moodle/popover-region.scss:$region-container-width: 380px;
      moodle/popover-region.scss:$region-container-z-index: 1;
      moodle/popover-region.scss:$region-header-height: 25px;
      moodle/popover-region.scss:$region-footer-height: 30px;
      moodle/popover-region.scss:$content-item-hover-colour-bg: $primary;
      moodle/popover-region.scss:$content-item-hover-colour-text: #fff;
      moodle/popover-region.scss:$content-item-selected-colour-bg: #4f94cd;
      moodle/popover-region.scss:$content-item-unread-colour: #f4f4f4;
      moodle/popover-region.scss:$content-header-footer-height: $region-header-height + $region-footer-height;
      moodle/reportbuilder.scss:    $inner-scrollbar-thumb: $secondary;
      moodle/reportbuilder.scss:    $inner-scrollbar-track: lighten($secondary, 40%);
      moodle/reportbuilder.scss:$rb-left-sidebar-width: 250px;
      moodle/reportbuilder.scss:$rb-right-sidebar-width: 350px;
      moodle/reportbuilder.scss:    $tabs-height: 83px;
      moodle/reportbuilder.scss:    $sidebar-margin-top: $navbar-height + $tabs-height + 20px;
      moodle/tool_usertours.scss:$flexitour-base-zindex: 1040;
      moodle/tool_usertours.scss:        $opposite: map_get($opposites, $direction);
      moodle/tool_usertours.scss:        $side: map_get($sides, $direction);
      moodle/tool_usertours.scss:        $oppositeside: map_get($opposites, $side);
      moodle/variables.scss:$primary-light-color: $body-color;
      moodle/variables.scss:$activity-iconcontainer-height: 50px;
      moodle/variables.scss:$activity-iconcontainer-width: 50px;
      preset/default.scss:$info-outline:    #1f7e9a;
      preset/default.scss:$warning-outline: #a6670e;
      preset/default.scss:$card-group-margin: .25rem;
      preset/default.scss:$custom-control-indicator-size: 1.25rem;
      preset/default.scss:$dropdown-link-hover-color: $white;
      preset/default.scss:$dropdown-link-hover-bg: $primary; 

      It would be good to have all of them suffixed with !default so that they can be overriden when necessary.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bawjaws David Scotson
              Amy Groshek, David Scotson, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: