Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74898

Remove NO_MOODLE_COOKIES from android app manifest

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_403_STABLE
    • MDL-74898-master
    • Hide
      1. In order to test this issue you will need: a test site running https, a real Android device with Android 5 onwards, Google Play installed with the latest Chrome browser installed. (you might find ngrok helpful). Please note you cannot use browserstack to test this issue.
      2. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      3. Enable App Banners in Site administration ► Mobile app ► Mobile appearance
      4. In your Mobile device uninstall the Moodle Mobile app (if it was installed)
      5. Then, open your Chrome browser and visit this url: chrome://flags/
      6. Look for this setting: bypass-app-banner-engagement-checks and enable it (you will be asked to re-launch Chrome)
      7. Then, visit your https testing site and check that you see the Moodle Mobile app install banner at the bottom of the page, check that you can install the app from there (you just need to check that the installer launches, no need to install the app)
      Show
      In order to test this issue you will need: a test site running https, a real Android device with Android 5 onwards, Google Play installed with the latest Chrome browser installed. (you might find ngrok helpful). Please note you cannot use browserstack to test this issue. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Enable App Banners in Site administration ► Mobile app ► Mobile appearance In your Mobile device uninstall the Moodle Mobile app (if it was installed) Then, open your Chrome browser and visit this url: chrome://flags/ Look for this setting: bypass-app-banner-engagement-checks and enable it (you will be asked to re-launch Chrome) Then, visit your https testing site and check that you see the Moodle Mobile app install banner at the bottom of the page, check that you can install the app from there (you just need to check that the installer launches, no need to install the app)
    • WP Sprint 2023-I1.2 (Marina), WP Sprint 2023-I1.3 (Marina), WP Sprint 2023-I1.4 (Espresso)

    Description

      I need to be able to suggest different mobile apps to different users (since different tenants in Moodle Workplace may have different branded apps).

      The android app id is not embedded in the page like ios app but instead we include a link to the manifest file and the manifest file contains app id.

      Manifest file declares NO_MOODLE_COOKIES for some reason - see https://github.com/moodle/moodle/blob/master/admin/tool/mobile/mobile.webmanifest.php#L31

      This issue suggests to remove NO_MOODLE_COOKIES so we can serve each user their own apps (we will modify env in the after_config hook).

      I'm going to create an issue here and pull this change into workplace code and see it it works, if it does, we can remove NO_MOODLE_COOKIES from core completely, it does not really add any value

      Attachments

        1. banner.png
          banner.png
          226 kB
        2. install_launcher.png
          install_launcher.png
          182 kB
        3. MDL-74898.jpg
          MDL-74898.jpg
          634 kB

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Juan Leyva Juan Leyva
              Huong Nguyen Huong Nguyen
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 19 minutes
                  7h 19m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.