Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74901

extend_navigation_frontpage now relies on the user having course:update capabilites to view the secondary navigation

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74901-400
    • MDL-74901-master
    • Hide

      Note: Please use a freshly installed site for all testing

      Regression test frontpage

      1. Make sure you're logged out
      2. Go to site home, e.g. http://YOURSITE/
      3. Verify you don't see any secondary navigation
      4. Log in as a user s1 - just an authenticated user, i.e no system roles
      5. Go to site home
      6. Verify you don't see any secondary navigation
      7. Log out
      8. Log in as the admin user
      9. Go to the site home
      10. Verify you see the following items in the secondary navigation:
        • Home
        • Settings
        • Participants
        • Reports
        • Question bank
        • More
      11. Verify that 'Home' is highlighted
      12. Expand 'More' and Verify you see the following items:
        • Content bank
        • Filters
        • Course reuse
      13. Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu):
        • Backup
        • Restore

      Regression test course

      1. Log in as an admin user
      2. Create a course
      3. Go to the course home
      4. Verify you see the following items in the secondary navigation:
        • Course
        • Settings
        • Participants
        • Grades
        • Reports
        • More
      5. Verify that 'Course' is highlighted
      6. Expand 'More' and Verify you see the following items:
        • Question bank
        • Content bank
        • Course completion
        • Badges
        • Competencies
        • Filters
        • Unenrol me from ...
        • Accessibility toolkit
        • Course reuse
      7. Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu):
        • Import
        • Backup
        • Restore
        • Copy course
        • Reset

      Callback test frontpage

      1. Pull in the testing commit, which just adds items using the course and frontpage nav callbacks.
        Master: 

        git fetch https://github.com/snake/moodle.git MDL-74901-master-testing && git merge --no-ff FETCH_HEAD

        400:

        git fetch https://github.com/snake/moodle.git MDL-74901-400-testing && git merge --no-ff FETCH_HEAD

      2. Log in to the site as an admin user
      3. Go to site home (frontpage)
      4. Verify you see the following items in the secondary navigation:
        • Home
        • Settings
        • Participants
        • Reports
        • Question bank
        • More
      5. Verify that 'Home' is highlighted
      6. Expand 'More' and Verify you see the following items:
        • Content bank
        • Filters
        • My custom nav item
        • Course reuse
      7. Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu):
        • Backup
        • Restore
      8. Log out. You should be on site home now.
      9. Verify you see the following items in the secondary navigation:
        • Home
        • My custom nav item
      10. Verify that 'Home' is highlighted
      11. Now, log in as the user s1
      12. Go to site home (frontpage)
      13. Verify you see the following items in the secondary navigation:
        • Home
        • My custom nav item
      14. Verify that 'Home' is highlighted

      Callback test course

      1. Log in as an admin user
      2. Go to the course you created earlier
      3. Verify you see the following items in the secondary navigation:
        • Course
        • Settings
        • Participants
        • Grades
        • Reports
        • More
      4. Verify that 'Course' is highlighted
      5. Expand 'More' and Verify you see the following items:
        • Question bank
        • Content bank
        • Course completion
        • Badges
        • Competencies
        • Filters
        • Unenrol me from ...
        • Accessibility toolkit
        • AAAAA Course nav callback item
        • Course reuse
      6. Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu):
        • Import
        • Backup
        • Restore
        • Copy course
        • Reset
      Show
      Note: Please use a freshly installed site for all testing Regression test frontpage Make sure you're logged out Go to site home, e.g. http://YOURSITE/ Verify you don't see any secondary navigation Log in as a user s1 - just an authenticated user, i.e no system roles Go to site home Verify you don't see any secondary navigation Log out Log in as the admin user Go to the site home Verify you see the following items in the secondary navigation: Home Settings Participants Reports Question bank More Verify that 'Home' is highlighted Expand 'More' and Verify you see the following items: Content bank Filters Course reuse Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu): Backup Restore Regression test course Log in as an admin user Create a course Go to the course home Verify you see the following items in the secondary navigation: Course Settings Participants Grades Reports More Verify that 'Course' is highlighted Expand 'More' and Verify you see the following items: Question bank Content bank Course completion Badges Competencies Filters Unenrol me from ... Accessibility toolkit Course reuse Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu): Import Backup Restore Copy course Reset Callback test frontpage Pull in the testing commit, which just adds items using the course and frontpage nav callbacks. Master: git fetch https://github.com/snake/moodle.git MDL-74901-master-testing && git merge --no-ff FETCH_HEAD 400: git fetch https://github.com/snake/moodle.git MDL-74901-400-testing && git merge --no-ff FETCH_HEAD Log in to the site as an admin user Go to site home (frontpage) Verify you see the following items in the secondary navigation: Home Settings Participants Reports Question bank More Verify that 'Home' is highlighted Expand 'More' and Verify you see the following items: Content bank Filters My custom nav item Course reuse Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu): Backup Restore Log out. You should be on site home now. Verify you see the following items in the secondary navigation: Home My custom nav item Verify that 'Home' is highlighted Now, log in as the user s1 Go to site home (frontpage) Verify you see the following items in the secondary navigation: Home My custom nav item Verify that 'Home' is highlighted Callback test course Log in as an admin user Go to the course you created earlier Verify you see the following items in the secondary navigation: Course Settings Participants Grades Reports More Verify that 'Course' is highlighted Expand 'More' and Verify you see the following items: Question bank Content bank Course completion Badges Competencies Filters Unenrol me from ... Accessibility toolkit AAAAA Course nav callback item Course reuse Go to "Course reuse" and Verify you now see the following items in the tertiary navigation (the select menu): Import Backup Restore Copy course Reset
    • 1
    • Team Hedgehog 4.1 sprint 0.1, Team Hedgehog 4.1 sprint 0.2

    Description

      In 4.0 we added the secondary navigation. We also added a capability check (course:update) to view the secondary navigation.

      This means that by default, only administrators can see the secondary navigation on the frontpage, and this callback has lost usefulness. It also means that navigation that was possible for all users has been taken away.

      Perhaps we can check to see if there are any items after this call back and show the secondary navigation to everyone if there is.

      Attachments

        1. 6_MDL-74901_v400.png
          6_MDL-74901_v400.png
          11 kB
        2. 6_MDL-74901_master.png
          6_MDL-74901_master.png
          12 kB
        3. 56_MDL-74901_v400.png
          56_MDL-74901_v400.png
          31 kB
        4. 56_MDL-74901_master.png
          56_MDL-74901_master.png
          25 kB
        5. 53_MDL-74901_v400.png
          53_MDL-74901_v400.png
          46 kB
        6. 53_MDL-74901_master.png
          53_MDL-74901_master.png
          31 kB
        7. 43_MDL-74901_v400.png
          43_MDL-74901_v400.png
          16 kB
        8. 43_MDL-74901_master.png
          43_MDL-74901_master.png
          10 kB
        9. 39_MDL-74901_v400.png
          39_MDL-74901_v400.png
          13 kB
        10. 39_MDL-74901_master.png
          39_MDL-74901_master.png
          7 kB
        11. 37_MDL-74901_v400.png
          37_MDL-74901_v400.png
          25 kB
        12. 37_MDL-74901_master.png
          37_MDL-74901_master.png
          25 kB
        13. 34_MDL-74901_v400.png
          34_MDL-74901_v400.png
          30 kB
        14. 34_MDL-74901_master.png
          34_MDL-74901_master.png
          31 kB
        15. 3_MDL-74901_v400.png
          3_MDL-74901_v400.png
          8 kB
        16. 3_MDL-74901_master.png
          3_MDL-74901_master.png
          9 kB
        17. 27_MDL-74901_v400.png
          27_MDL-74901_v400.png
          31 kB
        18. 27_MDL-74901_master.png
          27_MDL-74901_master.png
          42 kB
        19. 24_MDL-74901_v400.png
          24_MDL-74901_v400.png
          44 kB
        20. 24_MDL-74901_master.png
          24_MDL-74901_master.png
          45 kB
        21. 13_MDL-74901_v400.png
          13_MDL-74901_v400.png
          26 kB
        22. 13_MDL-74901_master.png
          13_MDL-74901_master.png
          18 kB
        23. 10_MDL-74901_v400.png
          10_MDL-74901_v400.png
          27 kB
        24. 10_MDL-74901_master.png
          10_MDL-74901_master.png
          27 kB

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-75714 theme_boost: Single activity format bug: Call to a member function remove() on bool

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-75296 Course admin menus not available in Boost for custom roles without course update privileges

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jaked Jake Dallimore
              abgreeve Adrian Greeve
              Stevani Andolo Stevani Andolo
              Ilya Tregubov Ilya Tregubov
              John Edward Pedregosa John Edward Pedregosa
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Sep/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 2 hours, 11 minutes
                  2d 2h 11m