Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74947

As Admin, when creating an external tool (LTI), "Shared secret" is truncated at < character

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-74947-311
    • MDL-74947-400
    • MDL-74947-master
    • Hide
      1. Login as Site Admin
      2. Go to: "Site administration / Plugins / Activity modules / External tool / Manage tools"
      3. Then click on "configure a tool manually"
      4. Put something in "Tool name" and "Tool URL"
      5. In "Shared secret" field, type text with a < character, like "rtyu<99" and validate with Enter
      6. Click on the eye icon to verify the value is ok
      7. Click "Save changes"
      8. Re-Edit the tool, and check "Shared secret" value by clicking again on the eye
      9. Verify the secret is still "rtyu<99"
      Show
      Login as Site Admin Go to: "Site administration / Plugins / Activity modules / External tool / Manage tools" Then click on "configure a tool manually" Put something in "Tool name" and "Tool URL" In "Shared secret" field, type text with a < character, like "rtyu<99" and validate with Enter Click on the eye icon to verify the value is ok Click "Save changes" Re-Edit the tool, and check "Shared secret" value by clicking again on the eye Verify the secret is still "rtyu<99"
    • 0
    • Team Hedgehog 4.1 sprint 0.1, Team Hedgehog 4.1 sprint 0.2

    Description

      As an admin, when you try to add (or update) an external tool (LTI), the "Shared secret" is truncated at the < character.

      Steps to reproduce:

      1. Login as Site Admin
      2. Go to: "Site administration / Plugins / Activity modules / External tool / Manage tools"
      3. Then click on "configure a tool manually"
      4. Put something in "Tool name" and "Tool URL"
      5. In "Shared secret" field, type text with a < character, like "rtyu<99" and validate with Enter
      6. Click on the eye icon to verify the value is ok
      7. Click "Save changes"
      8. Re-Edit the tool, and check "Shared secret" value by clicking again on the eye (It should be "rtyu<99" but is "rtyu" )

      The problem is the same if you edit a pre-existing tool.

      Seen in my 3.11.7 production Moodle, on my 4.0.1+ testing Moodle and https://sandbox.moodledemo.net/ and on 4.1dev Moodle on https://qa.moodledemo.net

      Certainly also existing in previous Moodle versions.

      I don't know if the same problem exists in other fields of the same type, elsewhere in Moodle... would certainly be interesting to check by someone knowing well when same type of field (or code) is used.

      Attachments

        1. MDL-74947_master.png
          MDL-74947_master.png
          65 kB
        2. MDL-74947_v311.png
          MDL-74947_v311.png
          57 kB
        3. MDL-74947_v400.png
          MDL-74947_v400.png
          70 kB

        Issue Links

          Activity

            People

              jaked Jake Dallimore
              fox Séverin Terrier
              Stevani Andolo Stevani Andolo
              Simey Lameze Simey Lameze
              John Edward Pedregosa John Edward Pedregosa
              Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              5 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                22/Aug/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 51 minutes
                  1h 51m