Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74958

Navigation customisation within plugins should use 'navigation' namespace (backport of MDL-74733)

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.5
    • 4.0.1, 4.0.3, 4.0.4
    • Navigation
    • None
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74958-master
    • Hide

      Test instructions copied from MDL-74733:

      1. On a test course, you will need one of each of the following activity types: assign, feedback, glossary, label, quiz. These can be created with all default options; you don't need any content.
      2. Go into each activity type (for the label it doesn't have its own page, but you can go to the settings page for it).
      3. CHECK there are no errors or warnings.
      4. Go into the 'Feedback' activity, using a large window so that it has the full space available, and look at the secondary navigation.
      5. CHECK the 'Responses' link is one of the top-level options (this is testing that the custom navigation works; without it, this link ends up in the More menu).
      6. You will also need an HTML block (if you don't already have one, go to blocks, add a block, and choose 'Text').
      7. Click the 'Configure' icon in the block header.
      8. CHECK the settings form appears with no errors or warnings. There is no secondary navigation on this page.
      Show
      Test instructions copied from MDL-74733 : On a test course, you will need one of each of the following activity types: assign, feedback, glossary, label, quiz. These can be created with all default options; you don't need any content. Go into each activity type (for the label it doesn't have its own page, but you can go to the settings page for it). CHECK there are no errors or warnings. Go into the 'Feedback' activity, using a large window so that it has the full space available, and look at the secondary navigation. CHECK the 'Responses' link is one of the top-level options (this is testing that the custom navigation works; without it, this link ends up in the More menu). You will also need an HTML block (if you don't already have one, go to blocks, add a block, and choose 'Text'). Click the 'Configure' icon in the block header. CHECK the settings form appears with no errors or warnings. There is no secondary navigation on this page.

      MDL-74733 (in 4.1) was about correcting a namespace name, required for use in plugins implementing new navigation.

      It would be simpler for plugin/in-house developers if the correct namespace were also available in 4.0 - especially at this point where many have probably not yet started working on 4.x.

      This is a simple cherry-pick of the code from 4.1 - the only changes are that I have removed the deprecation warnings and associated text in comments etc., and updated upgrade.txt.

        1. MDL-74958_master.mp4
          2.76 MB
        2. MDL-74958_v400.mp4
          2.36 MB

            quen Sam Marshall
            quen Sam Marshall
            Stevani Andolo Stevani Andolo
            Jun Pataleta Jun Pataleta
            John Edward Pedregosa John Edward Pedregosa
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 4 minutes
                3h 4m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.