Moodle
  1. Moodle
  2. MDL-7396 META BUG: Accessibility Compliance in Moodle 1.8
  3. MDL-7496

Quiz answers: 'incorrect' is read almost last - needs to be said first.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.8
    • Component/s: Accessibility, Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      Quiz answers: 'incorrect' is read almost last - needs to be said first.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Yu Zhang added a comment -

            Hi,

            Incorrect is read first for me after the question. Do you mean the feedback should go before the question?

            Show
            Yu Zhang added a comment - Hi, Incorrect is read first for me after the question. Do you mean the feedback should go before the question?
            Hide
            Yu Zhang added a comment -

            resolved in short answer question and child type questions

            Show
            Yu Zhang added a comment - resolved in short answer question and child type questions
            Hide
            Pierre Pichet added a comment -

            Yu,
            You resolved it for short and numerical question which parent is short.
            However this eliminate the calculated question type which has numerical as a virtualqtype.
            I know how to solve this problem, this is why I assign it to me.
            This is another place where the "special structure of calculated" is giving another problem!!!

            Show
            Pierre Pichet added a comment - Yu, You resolved it for short and numerical question which parent is short. However this eliminate the calculated question type which has numerical as a virtualqtype. I know how to solve this problem, this is why I assign it to me. This is another place where the "special structure of calculated" is giving another problem!!!
            Hide
            Pierre Pichet added a comment -

            Adding
            function print_question_grading_details(&$question, &$state, &$cmoptions, &$options)

            { $virtualqtype = $this->get_virtual_qtype(); $virtualqtype->print_question_grading_details($question, $state, $cmoptions, $options) ; }

            to calculated/questiontype.php so that the grading details are transfer to numerical then to shortanswer
            and
            modiftying function print_question_grading_details(&$question, &$state, $cmoptions, $options) {
            so that it refers to the good type get_correct_responses() function;
            global $QTYPES ;
            // MDL-7496 show correct answer after "Incorrect"
            $correctanswer = '';
            if ($correctanswers = $QTYPES[$question->qtype]->get_correct_responses($question, $state)) {

            This solve the problem for calculated without modifying the numerical and sort answer type

            Show
            Pierre Pichet added a comment - Adding function print_question_grading_details(&$question, &$state, &$cmoptions, &$options) { $virtualqtype = $this->get_virtual_qtype(); $virtualqtype->print_question_grading_details($question, $state, $cmoptions, $options) ; } to calculated/questiontype.php so that the grading details are transfer to numerical then to shortanswer and modiftying function print_question_grading_details(&$question, &$state, $cmoptions, $options) { so that it refers to the good type get_correct_responses() function; global $QTYPES ; // MDL-7496 show correct answer after "Incorrect" $correctanswer = ''; if ($correctanswers = $QTYPES [$question->qtype] ->get_correct_responses($question, $state)) { This solve the problem for calculated without modifying the numerical and sort answer type
            Hide
            Pierre Pichet added a comment -

            CVS done on Moodle Head and merged on 1.9_STABLE and 1.8_STABLE

            Show
            Pierre Pichet added a comment - CVS done on Moodle Head and merged on 1.9_STABLE and 1.8_STABLE

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: