Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74967

Get rid of $USER->groupmember hack

    XMLWordPrintable

Details

    • 1
    • HQ Team International CIH2-225

    Description

      This hack has been added ages ago to "speedup calendar display".

      That was added to load and cache user groups in the session during the login so when the user visit the calendar the group list is available in global $USER object and can be easily retrieved.

      The problem is that it doesn't pick up group and override changes, keeping the same groups from the time of login and because of that, newer creater overrides events won't be displayed in the calendar.

      This ticket is about properly removing that hack, we should use proper Group API function groups_get_user_groups() to get the list of groups the user belongs to.

      We should also add a mention to upgrade.txt

      Attachments

        Issue Links

          Activity

            People

              lameze Simey Lameze
              lameze Simey Lameze
              Huong Nguyen Huong Nguyen
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 50 minutes
                  4h 50m