Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75034

Move Report builder classes into /classes/reportbuilder/ namespace

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.1
    • 4.1
    • Report builder

    Description

      This issue is a follow-up to Jake's review on https://tracker.moodle.org/browse/MDL-74364.

      This is about moving Report builder classes into /classes/reportbuilder/ namespace and adding debugging calls to highlight cases where the entities (and any other reportbuilder-specific classes) are not located under the 'reportbuilder' level 2 namespace.

      "This will allow us to catch cases like this without needing to manually check during reviews. At a glance, I think add_entity() is a candidate for this, but we may also wish to consider ways to ensure specific reportbuilder namespaces are matched in the respective plugin implementations too. E.g. reportbuilder\systemreport, reportbuilder\entities, reportbuilder\audiences to name a few that are present in the plugins below. You'll note that some of these are in the PLUGINNAME\reportbuilder namespace while others are not.

      Other components which don't use the level 2 namespace for all reportbuilder classes (candidates for future update):

      • admin
      • cohort
      • report_configlog"

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              davidmatamoros David Matamoros
              Carlos Castillo Carlos Castillo
              Jun Pataleta Jun Pataleta
              CiBoT CiBoT
              Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                28/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 50 minutes
                  2h 50m