Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75072

Revert MDL-74623

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 4.1
    • 4.0.1
    • Forum
    • MOODLE_400_STABLE
    • MOODLE_401_STABLE
    • MDL-75072-master
    • Hide
      Setup
      1. Use MailHog or MailCatcher. Set up $CFG->smtphosts on your config.php to point to MailHog's/Catcher's URL (e.g. localhost:1025)
      Before upgrade
      1. Check out the weekly release:

        git checkout ceb41588d20

      2. Install the instance
      3. Create a course with full name and short name distinct from each other
      4. Enrol a student
      5. Go to Site administration / Plugins / Activity modules / Forum settings
      6. Tick "forum_usecoursefullname"
      7. Save the changes.
      8. On your favourite DB management tool, run the query

        SELECT * FROM mdl_config WHERE name = 'forum_usecoursefullname'
        

      9. Confirm a record is returned.
      Upgrade
      1. Checkout the version with the patch applied

        git checkout master

      2. Run the upgrade
      3. On your favourite DB management tool, run the query

        SELECT * FROM mdl_config WHERE name = 'forum_usecoursefullname'
        

      4. Confirm you don't get any results.
      Display course name
      1. Create a forum in the course with Subscription mode setting set to "Forced subscription"
      2. Create a discussion and post to the forum. Use the "Advanced" editor and make sure "Send forum post notifications with no editing-time delay" is ticked
      3. Run cron.
      4. Check the forum email.
      5. Confirm that the subject indicates the course's short name.
      6. Open a new browser tab.
      7. Go to "Site administration / Language / Language customisation"
      8. Choose the English language
      9. Open the language pack for editing. Press continue.
      10. Select "forum.php" in the "Show strings of these components" field and set "postmailsubject" on "String identifier" and press "Show strings"
      11. Under mod_forum / postmailsubject, set "Local customisation" to

        {$a->coursefullname}: {$a->subject}

        and click Save changes to the language pack

      12. Back on the forum browser tab, reply to the initial post and make sure to send forum notifications without editing time delay.
      13. Run cron
      14. Check the forum email
      15. Confirm that the subject indicates the course's full name.
      Show
      Setup Use MailHog or MailCatcher. Set up $CFG->smtphosts on your config.php to point to MailHog's/Catcher's URL (e.g. localhost:1025) Before upgrade Check out the weekly release: git checkout ceb41588d20 Install the instance Create a course with full name and short name distinct from each other Enrol a student Go to Site administration / Plugins / Activity modules / Forum settings Tick " forum_usecoursefullname " Save the changes. On your favourite DB management tool, run the query SELECT * FROM mdl_config WHERE name = 'forum_usecoursefullname' Confirm a record is returned. Upgrade Checkout the version with the patch applied git checkout master Run the upgrade On your favourite DB management tool, run the query SELECT * FROM mdl_config WHERE name = 'forum_usecoursefullname' Confirm you don't get any results. Display course name Create a forum in the course with Subscription mode setting set to " Forced subscription " Create a discussion and post to the forum. Use the "Advanced" editor and make sure " Send forum post notifications with no editing-time delay " is ticked Run cron. Check the forum email. Confirm that the subject indicates the course's short name. Open a new browser tab. Go to " Site administration / Language / Language customisation " Choose the English language Open the language pack for editing. Press continue. Select " forum.php" in the "Show strings of these components" field and set " postmailsubject " on " String identifier " and press " Show strings " Under mod_forum / postmailsubject , set " Local customisation " to {$a->coursefullname}: {$a->subject} and click Save changes to the language pack Back on the forum browser tab, reply to the initial post and make sure to send forum notifications without editing time delay. Run cron Check the forum email Confirm that the subject indicates the course's full name.

    Description

      Currently the subject line of forum notifications can be customised with various placeholders, as documented in https://docs.moodle.org/en/Forum_settings#Changing_the_subject_line_of_forum_notifications

      Let's add the placeholder coursefullname for sites wanting to include the course full name in the subject line of forum notifications.
      Edit: The following placeholders can be used already:

      • subject
      • forumname
      • sitefullname
      • siteshortname
      • courseidnumber
      • coursefullname
      • courseshortname

      Edited to add: As part of this issue, please can MDL-74623 be reverted, as it added an unneeded additional forum setting.

      Attachments

        1. customisedsubject.png
          customisedsubject.png
          103 kB
        2. customised subject.png
          customised subject.png
          45 kB
        3. MDL-75072_before upgrade.png
          MDL-75072_before upgrade.png
          64 kB
        4. MDL-75072_display course name_1.png
          MDL-75072_display course name_1.png
          72 kB
        5. MDL-75072_display course name_2.png
          MDL-75072_display course name_2.png
          69 kB
        6. MDL-75072_upgrade.png
          MDL-75072_upgrade.png
          67 kB
        7. MDL-75072 confirmation before.png
          MDL-75072 confirmation before.png
          9 kB
        8. MDL-75072 display confirmation.png
          MDL-75072 display confirmation.png
          54 kB
        9. MDL-75072 upgrade.png
          MDL-75072 upgrade.png
          7 kB

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              tsala Helen Foster
              Simey Lameze Simey Lameze
              Shamim Rezaie Shamim Rezaie
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 20 minutes
                  3h 20m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.