[MDL-75085] Undefined variable $required in Web Services API documentation page - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.11.7, 4.0.1, 4.0.6, 4.1.1
Fix Version/s: 4.0.7, 4.1.2
Component/s: Web Services
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.0 Branch:
~~MDL-75085~~-400-4
Pull 4.0 Diff URL:
https://github.com/junpataleta/moodle/compare/f5ec0df5d5...MDL-75085-400-4
Pull 4.1 Branch:
~~MDL-75085~~-401-4
Pull 4.1 Diff URL:
https://github.com/junpataleta/moodle/compare/67bbf6c416...MDL-75085-401-4
Pull Master Branch:
~~MDL-75085~~-master-4
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/880462a168...MDL-75085-master-4
Testing Instructions:
Hide

Make sure developer debugging is enabled (using mdk, "mdk run mindev")

Make sure the PHP config display_errors is also set to true

Log in as admin

Go to Site administration / Server / Web services / API Documentation

Confirm that you don't see the "Underfined variable $required" warning or any debugging messages.
Show
Make sure developer debugging is enabled (using mdk, " mdk run mindev ") Make sure the PHP config display_errors is also set to true Log in as admin Go to Site administration / Server / Web services / API Documentation Confirm that you don't see the " Underfined variable $required " warning or any debugging messages.

Description

To reproduce:

Make sure developer debugging is enabled and display errors is true
Log in as admin
Go to Site administration / Server / Web services / API Documentation

What happens:

The following warning is shown:

Warning: Undefined variable $required in /Users/jun/Work/moodles/integration_master/moodle/webservice/renderer.php on line 400

Warning: Undefined variable $required in /Users/jun/Work/moodles/integration_master/moodle/webservice/renderer.php on line 400

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

(I) Passed -- MDL-75085.png
225 kB
02/Feb/23 12:56 PM

Issue Links

Discovered while testing

MDL-29717 deprecated web service functions are displayed into the API documentation

Closed

has a non-specific relationship to

MDL-76583 Move lib/externallib.php to namespaced classes and fix coding style, etc.

Closed

is blocked by

MDL-77027 Web service documentation missing core_external

Closed

is duplicated by

MDL-75240 Wrong second argument in external_format_value()

Closed

MDL-77028 core_tag_get_tags has incorrect definition

Closed

links to

Developer update notes for $required parameter validation

(1 links to)

Activity

People

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Marina Glancy

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Jun Pataleta, Kim Jared Lucas, Marina Glancy, Ron Carl Alfon Yu

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 29/Jun/22 12:01 AM

Updated:: 03/Feb/23 6:08 PM

Resolved:: 03/Feb/23 6:08 PM

Fix Release Date:: 13/Mar/23

Time Tracking

Estimated:

Remaining:

Logged:

4h 3m