Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75091

Forum navigation nodes of forumreport all called the same

    XMLWordPrintable

Details

    • Bug
    • Status: Reopened
    • Minor
    • Resolution: Unresolved
    • 4.0.1, 4.1.5, 4.2.2, 4.3
    • None
    • Forum

    Description

      Forumreports are added to the navigation_node of the forum component. Moodle 4.x fetches the same string 'reports' for all reportnames being placed in the navigation of the forum. The moodle-core only has one report called summary, thus things only start getting confusing, when you add another forumreport plugin.

      The screenshot shows the faulty behaviour, not the desired one: two menu items being called "Reports" both leading to different links. One is the default summary forumreport of the Moodle Core, the other one is a custom forumreport.

      mod/forum/lib.php in line 5606

      $forumnode->add(get_string('reports'), $reportlink, navigation_node::TYPE_CONTAINER);
      

      In former versions it used to fetch the 'nodetitle' string from the forumreport:

      $forumnode->add(get_string('nodetitle', "forumreport_{$reportname}"), $reportlink, navigation_node::TYPE_CONTAINER);
      

      This seems like the intended behaviour.

      Attachments

        Activity

          People

            Unassigned Unassigned
            linos André Menrath
            Luca Bösch Luca Bösch
            Mathew May Mathew May
            Votes:
            8 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 1 minute
                3h 1m