Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75116

feedback multichoice[rated] emits php warnings under php8

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 3.11.8, 4.0.2
    • 3.11.7, 4.0.1
    • Feedback
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • Hide
      1. This is covered by CI tests, actually.
      2. Optionally, you can try also locally by:
        1. In a PHP8 environment
        2. Init behat.
        3. Run the behat tests for mod_feedback using --tags="~@javascript&&@mod_feedback"
        4. Verify you don't get any test failure or debugging/php warning in the web server error logs.
      Show
      This is covered by CI tests, actually. Optionally, you can try also locally by: In a PHP8 environment Init behat. Run the behat tests for mod_feedback using --tags="~@javascript&&@mod_feedback" Verify you don't get any test failure or debugging/php warning in the web server error logs.

    Description

      In a couple of places, the multichoice and multichoicerated feedback item types use the php @ operator to silence what would otherwise emit a message about trying to access an array element that doesn't exist.

      Under php8, this now more loudly emits a PHP Warning.

      Attachments

        Activity

          People

            aolley Adam Olley
            aolley Adam Olley
            Victor Déniz Falcón Victor Déniz Falcón
            Jun Pataleta Jun Pataleta
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.