[MDL-75116] feedback multichoice[rated] emits php warnings under php8 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.7, 4.0.1
Fix Version/s: 3.11.8, 4.0.2
Component/s: Feedback
Labels:
- ci

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Epic Link:
Prepare Moodle for PHP 8.0
Pull from Repository:
https://github.com/aolley/moodle.git
Pull 3.11 Branch:
~~MDL-75116~~_311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...aolley:MDL-75116_311
Pull 4.0 Branch:
~~MDL-75116~~_400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...aolley:MDL-75116_400
Pull Master Branch:
~~MDL-75116~~
Pull Master Diff URL:
https://github.com/aolley/moodle/compare/master...MDL-75116
Testing Instructions:
Hide

This is covered by CI tests, actually.

Optionally, you can try also locally by:

In a PHP8 environment

Init behat.

Run the behat tests for mod_feedback using --tags="~@javascript&&@mod_feedback"

Verify you don't get any test failure or debugging/php warning in the web server error logs.
Show
This is covered by CI tests, actually. Optionally, you can try also locally by: In a PHP8 environment Init behat. Run the behat tests for mod_feedback using --tags="~@javascript&&@mod_feedback" Verify you don't get any test failure or debugging/php warning in the web server error logs.

Description

In a couple of places, the multichoice and multichoicerated feedback item types use the php @ operator to silence what would otherwise emit a message about trying to access an array element that doesn't exist.

Under php8, this now more loudly emits a PHP Warning.

Attachments

Activity

People

Assignee:: Adam Olley

Reporter:: Adam Olley

Peer reviewer:: Victor Déniz Falcón

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: Adam Olley, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Victor Déniz Falcón

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 04/Jul/22 7:16 PM

Updated:: 07/Jul/22 10:23 PM

Resolved:: 07/Jul/22 10:23 PM

Fix Release Date:: 11/Jul/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

35m