Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75118

mod_label messes up layout if content width too big

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Not a bug
    • Icon: Minor Minor
    • None
    • 4.0.1, 4.0.3
    • Course
    • MOODLE_400_STABLE
    • MDL-75118-master
    • Hide
      1. Create a course
      2. Add a label
      3. insert an image with a big width (1200px for example, should be more than the course content width in your current browser window)
      4. Without patch: Overflow will happen, course content will have a scrollbar, see screenshots
      5. With patch: Label will have a scrollbar added, no overflow, course layout will be fine, see other screenshot
      6. This behavior can be observed in boost as well as in classic theme, fix works for both.
      Show
      Create a course Add a label insert an image with a big width (1200px for example, should be more than the course content width in your current browser window) Without patch: Overflow will happen, course content will have a scrollbar, see screenshots With patch: Label will have a scrollbar added, no overflow, course layout will be fine, see other screenshot This behavior can be observed in boost as well as in classic theme, fix works for both.

      If the content's width of a mod_label (for example an inserted picture) is too high the whole label will expand beyond the border set by the current format/theme, see screenshot. In Topics format this is not that bad, it is "just" being cut off and looks a bit ugly. However, you cannot access the cut off content at all. In other course formats this could be even worse, see screenshot of tiles_format.

       

      I suggest to add overflow-x: auto to the selector .activity-item .contentwithoutlink

      This at least does not mess up the whole course layout.

        1. Captura de pantalla 2022-08-24 a las 13.25.30.png
          Captura de pantalla 2022-08-24 a las 13.25.30.png
          125 kB
        2. Problematic label in boost theme.png
          Problematic label in boost theme.png
          154 kB
        3. Problematic label in boost theme with patch applied.png
          Problematic label in boost theme with patch applied.png
          317 kB
        4. Problematic label in classic theme.png
          Problematic label in classic theme.png
          247 kB
        5. Problematic label with theme boost in format_tiles.png
          Problematic label with theme boost in format_tiles.png
          261 kB

            phmemmel PhMemmel
            phmemmel PhMemmel
            Sebastian Gundersen Sebastian Gundersen
            Votes:
            10 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 minutes
                2m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.