Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75177

Improve callback for 'Category name' column

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.2
    • 4.0.1, 4.0.2, 4.2
    • Report builder
    • MOODLE_400_STABLE, MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • Hide

      Regression test

      1. Log in as admin
      2. Navigate to Plugins > Filters > Manage filters in site administration
      3. Set Multi-Language Content to On and Apply to Content and headings
      4. Navigate to Courses > Manage courses and categories in site administration
      5. Rename default category to the following:

        <span class="multilang" lang="en">Miscellaneous (EN)</span><span class="multilang" lang="de">Miscellaneous (DE)</span>
        

      6. Create a course in the category
      7. Navigate to Reports in user menu
      8. Create new report from Courses report source
        • Ensure Include default setup is unchecked
      9. In report editor, add the following column:
        • Course category > Category name
      10. Confirm category name is shown in report as Miscellaneous (EN)
      Show
      Regression test Log in as admin Navigate to Plugins > Filters > Manage filters in site administration Set Multi-Language Content to On and Apply to Content and headings Navigate to Courses > Manage courses and categories in site administration Rename default category to the following: <span class="multilang" lang="en">Miscellaneous (EN)</span><span class="multilang" lang="de">Miscellaneous (DE)</span> Create a course in the category Navigate to Reports in user menu Create new report from Courses report source Ensure Include default setup is unchecked In report editor, add the following column: Course category > Category name Confirm category name is shown in report as Miscellaneous (EN)

      In order to avoid DB read in 'Category name' column(s) callback, we need to refactor it to avoid extra DB queries where possible, by pre-loading category context data in a similar manner to MDL-75119

            pholden Paul Holden
            carlos.castillo@moodle.com Carlos Castillo
            Carlos Castillo Carlos Castillo
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.