Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75185

Custom report sources selection is not ordered consistently

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      To test this, we'll change the language string used by one of the report sources (lang/en/badges.php):

      1. Edit the 'badges' string in the aforementioned file to 'ZZ Badges', e.g. this diff:

        -$string['badges'] = 'Badges';
        +$string['badges'] = 'ZZ Badges';
        

      2. Purge lang string caches
      3. Navigate to Reports from user menu
      4. Press New report
      5. Enter a name
      6. Expand the Report source select element
      7. Confirm the sources are listed alphabetically (ZZ Badges should be last)
      8. Select the ZZ Badges report source
      9. Press Save
      10. Confirm a new report is created from the badges report source
      Show
      To test this, we'll change the language string used by one of the report sources ( lang/en/badges.php ): Edit the 'badges' string in the aforementioned file to 'ZZ Badges' , e.g. this diff: -$string['badges'] = 'Badges'; +$string['badges'] = 'ZZ Badges'; Purge lang string caches Navigate to Reports from user menu Press New report Enter a name Expand the Report source select element Confirm the sources are listed alphabetically ( ZZ Badges should be last) Select the ZZ Badges report source Press Save Confirm a new report is created from the badges report source

      The report manager class method for returning custom report sources across the site doesn't order the sources by component alphabetically:

      It should, to make new sources logically placed and easier to locate

        1. filter.png
          filter.png
          19 kB
        2. MDL-75185_master.png
          MDL-75185_master.png
          175 kB
        3. MDL-75185_v400.png
          MDL-75185_v400.png
          167 kB
        4. newreport.png
          newreport.png
          23 kB

            pholden Paul Holden
            pholden Paul Holden
            David Carrillo David Carrillo
            Ilya Tregubov Ilya Tregubov
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 20 minutes
                1h 20m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.