Loading...

XML

Word

Printable

Type: Task
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: Future Dev
Component/s: Database activity module
Labels:
- ci
- triaged

Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
MDL-75189_final-deprecation-of-functions-in_mod-data-lib.php
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-75189_final-deprecation-of-functions-in_mod-data-lib.php

Testing Instructions:

Hide

Confirm all automated tasks are happy (Behat and Unittest)

Execute the following:

git grep -n -C2 'data_print_template(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_preset_name(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_get_available_presets(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_get_available_site_presets(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_delete_site_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'is_directory_a_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_presets_save(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_presets_generate_xml(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_presets_export(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_user_can_delete_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

git grep -n -C2 'data_view(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

Confirm it returns nothing.

Execute the following:

git grep -n -C2 'is_directory_a_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

Confirm it only returns false positive of the new preset::is_directory_a_preset().

Execute the following:

git grep -n -C2 'import_setting_mappings(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt'

Confirm it only returns the function stub in \mod_data_renderer.

Show

Confirm all automated tasks are happy (Behat and Unittest) Execute the following: git grep -n -C2 'data_print_template(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_preset_name(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_get_available_presets(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_get_available_site_presets(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_delete_site_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'is_directory_a_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_presets_save(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_presets_generate_xml(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_presets_export(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_user_can_delete_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' git grep -n -C2 'data_view(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' Confirm it returns nothing. Execute the following: git grep -n -C2 'is_directory_a_preset(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' Confirm it only returns false positive of the new preset::is_directory_a_preset() . Execute the following: git grep -n -C2 'import_setting_mappings(' -- ':!lib/deprecatedlib.php' ':!.upgradenotes/MDL-75189-2024100107115232.yml' ':!mod/data/upgrade.txt' Confirm it only returns the function stub in \mod_data_renderer .

Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-75189 using repository: https://github.com/ziegenberg/moodle

main (0 errors / 0 warnings) [branch: MDL-75189_final-deprecation-of-functions-in_mod-data-lib.php | CI Job]

_{More information about this report}

Built on: Mon Jan 13 11:50:14 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-75189 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-75189_final-deprecation-of-functions-in_mod-data-lib.php | CI Job ] More information about this report Built on: Mon Jan 13 11:50:14 AM UTC 2025

In ~~MDL-75059~~, ~~MDL-75148~~ and ~~MDL-75187~~ several improvements have been implemented to the Database activity.

A few functions have been deprecated in order to move them to the new API (to remove them from the legacy lib.php). This issue is for the final deprecation of all these functions.

has a non-specific relationship to

MDL-75140 Skip fields mappings form if there are not fields created

Closed

has been marked as being related by

MDL-75059 Moodle 4.1 Database project - user experience improvements for teacher and students

Closed

MDL-75148 Improve Presets management list page for Database activity

Closed

MDL-75187 Move "Delete" preset confirmation to a modal

Closed

Assignee:: Daniel Ziegenberg

Reporter:: Sara Arjona (@sarjona)

Participants:: CiBoT, Daniel Ziegenberg, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Created:: 08/Jul/22 10:10 PM

Updated:: 2 days ago 7:50 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify