Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75205

Resetting report filters need to include original parameters

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-75205-400
    • Hide
      1. Log in as admin
      2. Navigate to Reports from user menu
      3. Create new report (any source)
      4. In report editor, not the report ID from the URL: 

        <WWWROOT>/reportbuilder/edit.php?id=<REPORTID>

      5. Press Audience tab
      6. Add All users audience and save changes
      7. Press Access tab
      8. Open your browser developer tools, to view network requests
      9. Press Filters
      10. Set Fullname filter to Contains: <sometext>, press apply
      11. Press Reset all button in filters form
      12. Inspect the call to core_reportbuilder_filters_reset in browser network requests
      13. Confirm the args property of the request structure contains the following: 

        parameters:	"{\"id\":\"<REPORTID>\"}"

      Show
      Log in as admin Navigate to Reports from user menu Create new report (any source) In report editor, not the report ID from the URL: <WWWROOT>/reportbuilder/edit.php?id=<REPORTID> Press Audience tab Add All users audience and save changes Press Access tab Open your browser developer tools, to view network requests Press Filters Set Fullname filter to Contains: <sometext> , press apply Press Reset all button in filters form Inspect the call to core_reportbuilder_filters_reset in browser network requests Confirm the args property of the request structure contains the following: parameters: "{\"id\":\"<REPORTID>\"}"
    • WP 4.0 SP7

    Description

      If a report relies upon parameters during initialization, e.g. during validation, then we need to include those parameters when resetting all user filters of a report, to ensure user can actually view said report

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-75154 Investigate feasibility of utilising the report builder within gradebook redesign

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-75235 Make it easier for reports to provide custom filter form implementations

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Roberto Bravo Roberto Bravo
              Jun Pataleta Jun Pataleta
              John Edward Pedregosa John Edward Pedregosa
              David Carrillo, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                22/Aug/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 5 hours, 50 minutes
                  1d 5h 50m