[MDL-75244] Form change checker uses TinyMCE API without checking it exists - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.8, 4.0.2
Fix Version/s: 3.11.9, 4.0.3
Component/s: Forms Library
Labels:
- ci

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 3.11 Branch:
~~MDL-75244~~-311
Pull 3.11 Diff URL:
https://github.com/andrewnicols/moodle/compare/8de4b14be7...MDL-75244-311
Pull 4.0 Branch:
~~MDL-75244~~-400
Pull 4.0 Diff URL:
https://github.com/andrewnicols/moodle/compare/2ccd0743fb...MDL-75244-400
Pull Master Branch:
~~MDL-75244~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/4ce642e8ba...MDL-75244-master

Testing Instructions:

Hide

Log in
Navigate to the user profile
Open the developer tools
In the Console, possibly under settings, ensure that "Preserve log" is selected
Run the following in the console:
window.tinyMCE = {};

Refresh the page

Confirm that no errors were reported about reading properties of undefined, for example:

Uncaught TypeError: Cannot read properties of undefined (reading 'some')

    at isAnyWatchedFormDirty (/sm/lib/requirejs.php/-1/core_form/changechecker.js:51:1867)

    at beforeUnloadHandler (/sm/lib/requirejs.php/-1/core_form/changechecker.js:51:2787)

Show

Log in Navigate to the user profile Open the developer tools In the Console, possibly under settings, ensure that "Preserve log" is selected Run the following in the console: window.tinyMCE = {}; Refresh the page Confirm that no errors were reported about reading properties of undefined , for example: Uncaught TypeError: Cannot read properties of undefined (reading 'some') at isAnyWatchedFormDirty (/sm/lib/requirejs.php/-1/core_form/changechecker.js:51:1867) at beforeUnloadHandler (/sm/lib/requirejs.php/-1/core_form/changechecker.js:51:2787)

Description

The Form Change Checker uses the window.tinyMCE API, and checks it exists, but it also uses window.tinyMCE.editors, which is a TinyMCE v3 feature.

Newer versions of TinyMCE use a proper API for fetching editor instances and this causes the FCC to throw an error when checking the Editors.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-75244_master.png
138 kB
03/Aug/22 10:56 AM
MDL-75244_v311.png
116 kB
03/Aug/22 10:56 AM
MDL-75244_v400.png
123 kB
03/Aug/22 10:56 AM

Issue Links

blocks

MDL-75071 Deprecate Atto in favour of Tiny 6

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Huong Nguyen

Integrator:: Jun Pataleta

Tester:: John Edward Pedregosa

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, John Edward Pedregosa, Jun Pataleta

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 19/Jul/22 12:36 PM

Updated:: 05/Aug/22 12:59 PM

Resolved:: 05/Aug/22 12:59 PM

Fix Release Date:: 22/Aug/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 54m