Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75371

Replace code comment with inclusive explanation

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 4.3
    • 4.0.2, 4.3
    • Installation

    Description

      I've been trying to setup moodle (still unsuccessfully so far but it's not the point of this ticket EDIT: success!. But it's irrelevant to the ticket) for a certain number of days, on my own time.

      That's all and well and I can keep trying exploring the code and find what I'm doing wrong.

      What I'm not really ok with is looking at the code of moodle, finding where my issue seems to be, and then just above, seeing a comment that reads:

      https://github.com/moodle/moodle/blob/4ce642e8ba568ca50dd71f77c0e231a5676ec8c1/lib/setuplib.php#L913-L914

                    // Hopefully this will stop all those "clever" admins trying to set up moodle
              
                    // with two different addresses in intranet and Internet. 

      You're very welcome to have whatever opinions on whatever horrible setup people might be doing, and for what it's worth, I'm not even trying to do what this comment says.

      But it's highly unrespectful publicly calling the admins not clever (or whatever those quotes around clever imply).

      This comment seems to have been there for the last 13 years. I'm sure there was a very good reason back then and the project was different.

      I think it's time to change this comment for something more neutral

      Cheers

      Attachments

        Activity

          People

            ewjoachim ewjoachim
            ewjoachim ewjoachim
            Andrew Lyons Andrew Lyons
            Paul Holden Paul Holden
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 39 minutes
                39m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.