[MDL-75375] Cache api should not use PARAM_SAFEDIR - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.9.15, 3.11.8, 4.0.2
Fix Version/s: 3.11.9, 4.0.3
Component/s: Caching
Labels:
- CatalystIT
- ci
- partner
- regression

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 3.11 Branch:
~~MDL-75375~~-311
Pull 3.11 Diff URL:
https://github.com/junpataleta/moodle/compare/8a147fee4b...MDL-75375-311
Pull 4.0 Branch:
~~MDL-75375~~-400
Pull 4.0 Diff URL:
https://github.com/junpataleta/moodle/compare/8eb4217a49...MDL-75375-400
Pull Master Branch:
~~MDL-75375~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/35b993b694...MDL-75375-master
Testing Instructions:
Hide

Go to cache admin /cache/admin.php

Click Add instance for a File cache store

Enter an absolute path eg /tmp/moodlecache and a name

Tick "Auto create directory"

Save, then edit the instance and confirm the path is as you entered with the leading /

Check the contents of the /tmp folder.

Confirm that it contains a moodlecache folder.

Repeat step 3 with a windows style path c:\temp\moodlecache

Deselect "Auto create directory"

Save (Ignore the warnings)

Edit the instance and confirm the path is as you entered with the leading c:\temp\moodlecache
Show
Go to cache admin /cache/admin.php Click Add instance for a File cache store Enter an absolute path eg /tmp/moodlecache and a name Tick "Auto create directory" Save, then edit the instance and confirm the path is as you entered with the leading / Check the contents of the /tmp folder. Confirm that it contains a moodlecache folder. Repeat step 3 with a windows style path c:\temp\moodlecache Deselect "Auto create directory" Save (Ignore the warnings) Edit the instance and confirm the path is as you entered with the leading c:\temp\moodlecache

Description

Setting an absolute path in the file store cache no longer works due to improved cleaning rules in PARAM_SAFEDIR and the cache should never have used with param type in the first place.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-75375_master_1.png
72 kB
10/Aug/22 9:44 AM
MDL-75375_master_2.png
266 kB
10/Aug/22 9:44 AM
MDL-75375_master_3.png
89 kB
10/Aug/22 9:44 AM
MDL-75375_v311_1.png
71 kB
10/Aug/22 9:44 AM
MDL-75375_v311_2.png
249 kB
10/Aug/22 9:44 AM
MDL-75375_v311_3.png
91 kB
10/Aug/22 9:44 AM
MDL-75375_v400_1.png
70 kB
10/Aug/22 9:44 AM
MDL-75375_v400_2.png
272 kB
10/Aug/22 9:44 AM
MDL-75375_v400_3.png
88 kB
10/Aug/22 9:44 AM
MDL-75375-cache-path.patch
0.9 kB
04/Aug/22 7:20 PM

Activity

People

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Petr Skoda

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, Brendan Heywood, CiBoT, Jun Pataleta, Nicolas Martignoni, Petr Skoda

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 3 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 04/Aug/22 1:49 PM

Updated:: 12/Aug/22 11:41 AM

Resolved:: 12/Aug/22 11:41 AM

Fix Release Date:: 22/Aug/22

Time Tracking

Estimated:

Remaining:

Logged:

2h 15m