Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75536

Wrong conditional in the participants filter field "accesssince"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 3.9.16, 3.11.9, 4.0.3
    • Course

      The \core_user\output\participants_filter::get_filtertypes gets the data for all the filter types. The options for the inactive filter are set in the \core_user\output\participants_filter::get_accesssince_filter method. There is a conditional to decide if we are on a course or the front page:

      user/classes/output/participants_filter.php

      257     if (!$this->course->id == SITEID)
      

      This always returns false because the "!" operator is applied to $this->course->id. I guess the intention was:

      user/classes/output/participants_filter.php

      257     if (!($this->course->id == SITEID))
      

            vmdef Victor Déniz Falcón
            vmdef Victor Déniz Falcón
            Carlos Escobedo Carlos Escobedo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.