[MDL-75641] String for timezone europe/kyiv not found (tzdb 2022b) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.9.16, 3.11.9, 4.0.3, 4.1
Fix Version/s: 3.9.17, 3.11.10, 4.0.4
Component/s: Language, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 3.9 Branch:
~~MDL-75641~~_39
Pull 3.9 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-75641_39~1...MDL-75641_39
Pull 3.11 Branch:
~~MDL-75641~~_311
Pull 3.11 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-75641_311~1...MDL-75641_311
Pull 4.0 Branch:
~~MDL-75641~~_400
Pull 4.0 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-75641_400~1...MDL-75641_400
Pull Master Branch:
~~MDL-75641~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-75641~1...MDL-75641
Workaround:

Hide

Avoid using PHP 8.0.23 or PHP 8.1.10 (any PHP release after September 1st, 2022). Or avoid updating the timezones database in the system to 2022b or later if your PHP uses it.

Show
Avoid using PHP 8.0.23 or PHP 8.1.10 (any PHP release after September 1st, 2022). Or avoid updating the timezones database in the system to 2022b or later if your PHP uses it.
Testing Instructions:
Hide

Any (one) of these verifications should be enough:

[OR] Testing locally.

Requirements:

Ensure that you are using PHP 8.0.23 (php -v), install it if needed.

Also,ensure you've the latest time zones database, version 2022b (apt-get update && apt-get install tzdata).

Init phpunit (php admin/tool/phpunit/cli/init.php).

Run vendor/bin/phpunit lib/tests/date_test.php

Verify that it passes without any failure (specifically without any europe/kyiv failure).

[OR] Trust GHA runs, that are already using PHP 8.0.23

Look to the Github badges in this issue (near the branches information in this issue).

Verify that all them have passed ok (green).
Show
Any (one) of these verifications should be enough: [OR] Testing locally. Requirements: Ensure that you are using PHP 8.0.23 ( php -v ), install it if needed. Also,ensure you've the latest time zones database, version 2022b ( apt-get update && apt-get install tzdata ). Init phpunit ( php admin/tool/phpunit/cli/init.php ). Run vendor/bin/phpunit lib/tests/date_test.php Verify that it passes without any failure (specifically without any europe/kyiv failure). [OR] Trust GHA runs, that are already using PHP 8.0.23 Look to the Github badges in this issue (near the branches information in this issue). Verify that all them have passed ok (green).

Description

It seems that latest versions of PHP come with a version of IANA database (TZDB) time zones version 2022b that includes the change of Europe/Kiev to Europe/Kyiv (note the old name still remains as alias).

This PHP Bug confirms it: https://bugs.php.net/bug.php?id=80254

And this is the failure that we are getting when using the latest PHP versions using that time zones database:

Example run, using just released 8.0.23 (September 1st): https://github.com/stronk7/moodle/actions/runs/2979120020

1) core_date_testcase::test_timezone_lang_strings

String for timezone europe/kyiv not found.

Failed asserting that false is true.

D:\a\moodle\moodle\lib\tests\date_test.php:174

D:\a\moodle\moodle\lib\phpunit\classes\advanced_testcase.php:80

So this issue is about to add that new Europe/Kyiv in all supported versions.

As a reference, ~~MDL-72953~~ was exactly the same case. Trivial to fix, it seems, just add the new string.

Ciao

Attachments

Issue Links

has a non-specific relationship to

MDL-72953 String for timezone pacific/kanton not found

Closed

has been marked as being related by

MDL-76674 String for timezone america/ciudad_juarez not found (tzdb 2022g)

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Matteo Scaramuccia

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Matteo Scaramuccia

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 02/Sep/22 10:57 PM

Updated:: 14/Dec/22 10:41 PM

Resolved:: 09/Sep/22 10:47 AM

Fix Release Date:: 12/Sep/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 15m