Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75664

Display approval status in the database entries

XMLWordPrintable

    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • MDL-75664-master
    • Hide

      Entry approval for the default template is tested using behat.

      Manual tests for the presets:

      Setup:

      • Create a 3 database activity D1-image, D1-proposals and D1-journal
      • For each activity, make sure that the settings Entries/Approval required is set to Yes
      • In the zero state page of D1-image, select use preset and select "Image gallery"
        • Use the default mapping and continue
        • Create at least 2 entries
        • Unapprove the second entry by using the kebab menu
      • In the zero state page of D1-journal, select use preset and select "Journal"
        • Use the default mapping and continue
        • Create at least 2 entries
        • Unapprove the second entry by using the kebab menu
      • In the zero state page of D1-proposals, select use preset and select "Proposals"
        • Use the default mapping and continue
        • Create at least 2 entries
        • Unapprove the second entry by using the kebab menu

      For each database activity:

      As a student:

      • Ensure that there are no "Approved" label is on the first entry{}
      • Ensure that the "Pending approval" label is on the second entry
      • Look the single view for each entry and ensure that the "Pending approval" label is shown on the unapproved entry.
      • Check that the layout is ok and the labels are aligned vertically (the "Pending approval" label and the Kebab menu)

      As a teacher:

      • Ensure that there are no "Approved" label is on the first entry{}
      • Ensure that the "Pending approval" label is on the second entry
      • Look the single view for each entry and ensure that the "Pending approval" label is shown on the unapproved entry.
      • Check that the layout is ok and the labels are aligned vertically (the "Pending approval" label and the Kebab menu)
      • Approve the second entry by using the kebab menu
      • Ensure that the "Pending approval" label cannot be seen anymore on the second entry

       

      Show
      Entry approval for the default template is tested using behat. Manual tests for the presets: Setup: Create a 3 database activity D1-image, D1-proposals and D1-journal For each activity, make sure that the settings Entries/Approval required is set to Yes In the zero state page of D1-image, select use preset and select "Image gallery" Use the default mapping and continue Create at least 2 entries Unapprove the second entry by using the kebab menu In the zero state page of D1-journal, select use preset and select "Journal" Use the default mapping and continue Create at least 2 entries Unapprove the second entry by using the kebab menu In the zero state page of D1-proposals, select use preset and select "Proposals" Use the default mapping and continue Create at least 2 entries Unapprove the second entry by using the kebab menu For each database activity: As a student: Ensure that there are no "Approved" label is on the first entry { } Ensure that the "Pending approval" label is on the second entry Look the single view for each entry and ensure that the "Pending approval" label is shown on the unapproved entry. Check that the layout is ok and the labels are aligned vertically (the "Pending approval" label and the Kebab menu) As a teacher: Ensure that there are no "Approved" label is on the first entry { } Ensure that the "Pending approval" label is on the second entry Look the single view for each entry and ensure that the "Pending approval" label is shown on the unapproved entry. Check that the layout is ok and the labels are aligned vertically (the "Pending approval" label and the Kebab menu) Approve the second entry by using the kebab menu Ensure that the "Pending approval" label cannot be seen anymore on the second entry  
    • 2
    • HQ Sprint 0.4 Database

      While reviewing the comments raised by Helen in the presets wordings and suggestions document, we've realised the approval status is not displayed anymore in the current master branch (in 4.0 downwards, unapproved entries are displayed with a red background):

      Instead of using the background colour, the UX/PX team has decided to add a badge to the entries that require approval (as displayed in the prototype):

      This issue is to:

      • Re-add this information to the default templates. 
      • Add this information to all the presets (although the "Approval required" setting will be disabled by default in the presets, this information should be added to the templates to guarantee it's displayed when users enable it). 

        1. image-2022-09-12-17-30-14-832.png
          24 kB
          Laurent David
        2. image-2022-09-12-17-30-37-678.png
          21 kB
          Laurent David
        3. image-2022-09-12-17-31-13-398.png
          43 kB
          Laurent David
        4. image-2022-09-13-11-05-36-432.png
          11 kB
          Laurent David
        5. image-2022-09-14-07-07-24-596.png
          9 kB
          Laurent David
        6. image-2022-09-14-07-07-48-524.png
          16 kB
          Laurent David
        7. image-2022-09-14-07-08-37-880.png
          13 kB
          Laurent David
        8. image-2022-09-14-07-08-55-582.png
          16 kB
          Laurent David
        9. image-2022-09-14-07-33-18-326.png
          71 kB
          Laurent David
        10. image-2022-09-14-07-33-37-593.png
          21 kB
          Laurent David
        11. image-2022-09-14-07-34-25-174.png
          158 kB
          Laurent David
        12. image-2022-09-14-07-34-43-290.png
          78 kB
          Laurent David
        13. listview_pendingapproval.png
          401 kB
          Sara Arjona (@sarjona)
        14. MDL-75664_student.webm
          4.68 MB
          Angelia Dela Cruz
        15. MDL-75664_teacher.webm
          5.68 MB
          Angelia Dela Cruz
        16. pendingapproval_moodle40.png
          20 kB
          Sara Arjona (@sarjona)
        17. singleview_pendingapproval.png
          23 kB
          Sara Arjona (@sarjona)

            laurent.david@moodle.com Laurent David
            sarjona Sara Arjona (@sarjona)
            Carlos Escobedo Carlos Escobedo
            Ferran Recio Ferran Recio
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours, 39 minutes
                1d 5h 39m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.