Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75666

Identify same browser login by cookie instead of by IP

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-75666-400
    • MDL-75666-master
    • Hide
      Prerequisits
      1. MailHog or similar tool to capture emails coming out from Moodle
      Test notifications
      1. Open a browser in incognito mode
      2. Login to the Moodle site
      3. Run the cron job
      4. Confirm that there was one email sent, notifying you of a new login
      5. Logout of the Moodle site (but do not close the browser)
      6. Login to the Moodle site
      7. Run the cron job
      8. Confirm that there was no new email sent
      9. Close the browser (at least all incognito windows should be closed)
      10. Open a new incognito window (this is simulating a new device)
      11. Login to the Moodle site
      12. Run the cron job
      13. Confirm that there was one email sent, notifying you of a new login.
      Show
      Prerequisits MailHog or similar tool to capture emails coming out from Moodle Test notifications Open a browser in incognito mode Login to the Moodle site Run the cron job Confirm that there was one email sent, notifying you of a new login Logout of the Moodle site (but do not close the browser) Login to the Moodle site Run the cron job Confirm that there was no new email sent Close the browser (at least all incognito windows should be closed) Open a new incognito window (this is simulating a new device) Login to the Moodle site Run the cron job Confirm that there was one email sent, notifying you of a new login.

    Description

      In MDL-66776, emails were send upon logins on new devices, which is a great feature! We would love to force these notifications to be send (instead of letting the user decide), but sadly we can't, because there are too many cases, in which the feature is very annoying.

      In my understanding, in the pretty common scenario of daily logging in on one device in the morning for example at school or university, and one other device later, for example at home, is enough to already receive two mails per day. If you use moodle on your smartphone, and on a computer at work and at home, that number will only rise.

      This is a serious issue/flaw in my opinion, because it does not matter whether we send users these login emails, if they just ignore them because they are 'the norm'.

      Attachments

        Issue Links

          Activity

            People

              justusdieckmann Justus Dieckmann
              justusdieckmann Justus Dieckmann
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              18 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated: