[MDL-75746] Problems with backup and restore of quiz slots in Moodle 4.0 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.4, 4.0.7, 4.1, 4.1.2
Fix Version/s: 4.0.8, 4.1.3
Component/s: Quiz
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Epic Link:
Quiz and Question bank in Moodle 4.2
Pull from Repository:
https://github.com/marxjohnson/moodle.git
Pull 4.0 Branch:
~~MDL-75746~~_400_STABLE
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...marxjohnson:moodle:MDL-75746_400_STABLE
Pull 4.1 Branch:
~~MDL-75746~~_401_STABLE
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...marxjohnson:moodle:MDL-75746_401_STABLE
Pull Master Branch:
~~MDL-75746~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...marxjohnson:moodle:MDL-75746_master
Testing Instructions:

Hide

This is covered by unit tests (quiz_question_restore_test::test_backup_restore_question_slots).

Show
This is covered by unit tests (quiz_question_restore_test::test_backup_restore_question_slots).

Description

This is just wrong

https://github.com/moodle/moodle/blob/c6211a68b4f43754a9d593d5cf3f33f42c118c21/mod/quiz/backup/moodle2/backup_quiz_stepslib.php#L51

The bit of the backup corresponds to the quiz_slots table (different name because backwards-compatibility). The columns in this table are acutally https://github.com/moodle/moodle/blob/master/mod/quiz/db/install.xml#L58

I am a bit surpirsed this does not break any automated tests!

Attachments

Issue Links

Discovered while testing

MDL-74609 Quiz: allow the displayed question numbers to be customised

Closed

Activity

People

Assignee:: Mark Johnson

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Ilya Tregubov, Jun Pataleta, Mark Johnson, Safat Shahin, Tim Hunt

Component watchers:: Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 14/Sep/22 6:29 PM

Updated:: 20/Apr/23 12:28 AM

Resolved:: 22/Mar/23 10:56 AM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

0m

Remaining:

0m

Logged:

51m