[MDL-75836] moodleform_mod overwrites errors from moodleform - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.10, 4.0.4
Fix Version/s: 3.11.11, 4.0.5
Component/s: Forms Library
Labels:
- ci
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/jrchamp/moodle.git
Pull 3.11 Branch:
~~MDL-75836~~_311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...jrchamp:moodle:MDL-75836_311
Pull 4.0 Branch:
~~MDL-75836~~_400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...jrchamp:moodle:MDL-75836_400
Pull Master Branch:
~~MDL-75836~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...jrchamp:moodle:MDL-75836
Testing Instructions:
Hide

Open lib/formslib.php in your preferred editor

Find the validation($data, $files) function

Change the content of the function:

// From:

return array();

// To:

return [

'name' => 'Paumanhin',

];

Log in to Moodle as a teacher, or administrator

Open a course and turn editing mode on

Create a new assignment

Enter a name

Press the "Save and display" button

Confirm that an error was shown under the name with the error "Paumanhin"
Show
Open lib/formslib.php in your preferred editor Find the validation($data, $files) function Change the content of the function: // From: return array(); // To: return [ 'name' => 'Paumanhin', ]; Log in to Moodle as a teacher, or administrator Open a course and turn editing mode on Create a new assignment Enter a name Press the "Save and display" button Confirm that an error was shown under the name with the error "Paumanhin"

Description

In moodleform_mod::validation(), the parent::validation() call is made to allow the parent class (moodleform) to perform validation steps that may need to happen globally. However, two instructions later in the function, the errors array that was returned is immediately overwritten with an empty array.

This has been a problem since Moodle 2.0, but it doesn't cause any problems at this moment. However, fixing the issue now avoids future surprises.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-75836_master.png
22 kB
05/Oct/22 9:55 AM
MDL-75836_v311.png
23 kB
05/Oct/22 9:55 AM
MDL-75836_v400.png
22 kB
05/Oct/22 9:55 AM

Issue Links

has a non-specific relationship to

MDL-12133 problems with changed number of parameters of validate($date, $files)

Closed

Activity

People

Assignee:: Jonathan Champ

Reporter:: Jonathan Champ

Peer reviewer:: Paul Holden

Integrator:: Andrew Lyons

Tester:: John Edward Pedregosa

Participants:: Andrew Lyons, CiBoT, John Edward Pedregosa, Jonathan Champ, Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 27/Sep/22 7:23 AM

Updated:: 07/Oct/22 1:59 PM

Resolved:: 07/Oct/22 1:59 PM

Fix Release Date:: 14/Nov/22

Time Tracking

Estimated:

Remaining:

Logged:

2h 11m