Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75841

Web install broken after favicon changes

    XMLWordPrintable

Details

    Description

      MDL-75218 changed a few things - and importantly lib/outputrenderers.php. This now completely breaks the web install because we're trying to access config that doesn't yet exist in the DB. We see an error like this (which, without debugging isn't helpful at all):

      With debugging on, here's the stack trace:

      Debug info:
      Error code: ddltablenotexist
      Stack trace:    line 673 of /lib/dml/moodle_database.php: dml_exception thrown
          line 1711 of /lib/dml/moodle_database.php: call to moodle_database->where_clause()
          line 1517 of /lib/moodlelib.php: call to moodle_database->get_field()
          line 4273 of /lib/outputrenderers.php: call to get_config()
          line 219 of /lib/mustache/src/Mustache/Context.php: call to core_renderer->favicon()
          line 138 of /lib/mustache/src/Mustache/Context.php: call to Mustache_Context->findVariableInStack()
          line 29 of data/localcache/mustache/1/boost/__Mustache_79de2b7bc59b3edaf42bddd54f84759a.php: call to Mustache_Context->findDot()
          line 67 of /lib/mustache/src/Mustache/Template.php: call to __Mustache_79de2b7bc59b3edaf42bddd54f84759a->renderInternal()
          line 204 of /lib/outputrenderers.php: call to Mustache_Template->render()
          line 34 of /theme/boost/layout/maintenance.php: call to renderer_base->render_from_template()
          line 1473 of /lib/outputrenderers.php: call to include()
          line 1399 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
          line 543 of /lib/outputrenderers.php: call to core_renderer->header()
          line 42 of /admin/renderer.php: call to plugin_renderer_base->__call()
          line 232 of /admin/index.php: call to core_admin_renderer->install_licence_page()

      In particular, note:
      line 4273 of /lib/outputrenderers.php: call to get_config()

      This issue should find a solution to this, or revert the single commit added in 75218 failing that. Reverting 7adac1fefbeda10f1d52c99adfd72adac0da52a1 restores the web install behaviour to normal.

      Attachments

        1. MDL-75841_installation.webm
          665 kB
        2. MDL-75841_favicon_3.webm
          2.36 MB
        3. MDL-75841_favicon_2.png
          MDL-75841_favicon_2.png
          361 kB
        4. MDL-75841_favicon_1.png
          MDL-75841_favicon_1.png
          29 kB
        5. dml_exception.png
          dml_exception.png
          6 kB

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              jaked Jake Dallimore
              Mihail Geshoski Mihail Geshoski
              Jake Dallimore Jake Dallimore
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 40 minutes
                  1h 40m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.