Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75845

Don't show "value" field for report date filter "Current" operator

    XMLWordPrintable

Details

    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Reports in user menu
      3. Create a new report from Users report source
      4. In report editor, add User > Time created condition
      5. Set condition field to Last
      6. Confirm you see fields to enter value (number) and unit (days, weeks, etc)
      7. Set condition field to Current
      8. Confirm you see field to enter unit (days, weeks, etc), and do not see field to enter value (number)
      Show
      Log in as admin Navigate to Reports in user menu Create a new report from Users report source In report editor, add User > Time created condition Set condition field to Last Confirm you see fields to enter value (number) and unit (days, weeks, etc) Set condition field to Current Confirm you see field to enter unit (days, weeks, etc), and do not see field to enter value (number)

    Description

      Small regression from MDL-75639: https://github.com/moodle/moodle/commit/131a97406be36ff1da0fa734eb3dd74122ddfee2#diff-49984c54f796e5d7b99301893c56337c7c92065a4b92ea178653e480ae74eb09R121

      This line doesn't append the intended value to the array, which results in the "value" field being visible when using the "Current" date filter operator - which is confusing as it has no effect

      Attachments

        1. date current.png
          date current.png
          11 kB
        2. MDL-75845_current.png
          MDL-75845_current.png
          188 kB
        3. MDL-75845_last.png
          MDL-75845_last.png
          189 kB

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-75192 "Current week" condition in report builder always considers Monday as start of week

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-75639 Add "In the future" and "In the past" options to date filter

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              David Matamoros David Matamoros
              Jake Dallimore Jake Dallimore
              Angelia Dela Cruz Angelia Dela Cruz
              Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                28/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m