Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75883

Avoid reloading report content after deleting a filter

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.1
    • 4.1
    • Report builder
    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • MDL-75883-master
    • Hide
      1. Log in as Admin
      2. Navigate to Reports from the user menu
      3. Create a new report from Users report source
        • Ensure Include default setup is checked
      4. In report editor open the Filters dropdown
      5. Open Network inspector in your browser
      6. Delete the filter 'Full name'
      7. Ensure that there is only a call to 'core_reportbuilder_filters_delete' in the inspector and there is no call to 'core_table_get_dynamic_table_content'
      8. Ensure that the filter has been deleted from the editor
      Show
      Log in as Admin Navigate to  Reports from the user menu Create a new report from Users  report source Ensure Include default setup is checked In report editor open the Filters dropdown Open Network inspector in your browser Delete the filter 'Full name' Ensure that there is only a call to 'core_reportbuilder_filters_delete' in the inspector and there is no call to 'core_table_get_dynamic_table_content' Ensure that the filter has been deleted from the editor

    Description

      We reload the dynamic table after deleting a report filter: https://github.com/paulholden/moodle/blob/8f492a836a52952720d242b35ff1391445aa8e1e/reportbuilder/amd/src/local/editor/filters.js#L143

      This is a waste of time/resources because filters don't affect a report while editing

      Attachments

        Activity

          People

            davidmatamoros David Matamoros
            davidmatamoros David Matamoros
            Paul Holden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            John Edward Pedregosa John Edward Pedregosa
            Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              28/Nov/22

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 28 minutes
                1h 28m