Selection of active primary navigation node is not precise enough

Copy hello.php to your wwwroot Apply patch 75903.diff to your site: diff --git a/lib/classes/navigation/views/primary.php b/lib/classes/navigation/views/primary.php index 8ab9124..75c2806 100644 --- a/lib/classes/navigation/views/primary.php +++ b/lib/classes/navigation/views/primary.php @@ -70,6 +70,16 @@ class primary extends view { if ($showcoursesnode) { $this->add(get_string('mycourses'), new \moodle_url('/my/courses.php'), self::TYPE_ROOTNODE, null, 'mycourses'); } + + for ($i = 1; $i <= 3; $i++) { + $this->add( + "Page {$i}", + new \moodle_url('/hello.php', ['id' => $i]), + navigation_node::TYPE_ROOTNODE, + null, + "page-{$i}" + ); + } } $showsiteadminnode = empty($this->page->theme->removedprimarynavitems) || Log in as admin Press Page 1 in primary navigation Confirm only Page 1 is active Press Page 2 in primary navigation Confirm only Page 2 is active Press Page 3 in primary navigation Confirm only Page 3 is active Regression test: Press on each of Home / Dashboard / My courses / Site administration in primary navigation Confirm the item you clicked on is the active