Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75936

Race condition in message_drawer helper

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • 3.11.11, 4.0.5
    • 3.11.10, 4.0.4
    • Messages
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-75936-master
    • Hide

      Behat will largely test this but to see it in full:

      1. Login as any user
      2. From the user menu, choose "User preferences"
      3. Choose "Message preferences"
        1. Confirm that the preferences menu opens
      Show
      Behat will largely test this but to see it in full: Login as any user From the user menu, choose "User preferences" Choose "Message preferences" Confirm that the preferences menu opens

    Description

      On faster machines and connections, when visiting the legacy message preferences page, a race condition sometimes means that the event to capture the message drawer open request is fired before the event is subscribed to.

      This is highlighted by MDL-66107 which makes this behaviour more consistent.

      The master branch of this patch includes a rewrite for the module and events module as an ESM. This is a separate commit and should be viewed separately.

      Attachments

        1. MDL-75936_master.png
          57 kB
          John Edward Pedregosa
        2. MDL-75936_v311.png
          51 kB
          John Edward Pedregosa
        3. MDL-75936_v400.png
          37 kB
          John Edward Pedregosa
        4. Screen Shot 2022-10-11 at 2.32.59 pm.png
          161 kB
          David Woloszyn
        5. Screen Shot 2022-10-11 at 2.33.07 pm.png
          147 kB
          David Woloszyn
        6. Screen Shot 2022-10-11 at 2.34.15 pm.png
          151 kB
          David Woloszyn

        Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-66107 Stop bundling all files in first.js

          • Major - Major loss of function, incorrect output
          • Reopened

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Stevani Andolo Stevani Andolo
              Jun Pataleta Jun Pataleta
              John Edward Pedregosa John Edward Pedregosa
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 16 minutes
                  6h 16m