Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75937

Frontpage settings incorrectly display config.php

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-75937-401
    • MDL-75937-402
    • MDL-75937-master
    • Hide

      Note

      As proposed by Brendan and voted by Jun, the concept of the patch is changed to

      1. Maintain the current behaviour but only for the site home settings.
      2. Make "fullname, shortname, summary and newsitems" cannot be overriden.

      Testing the "fullname, shortname, summary and newsitems"

      1. Login as admin
      2. Go to <wwwroot>/admin/settings.php?section=frontpagesettings
      3. Set "Full site name" to "non-forced fullname" then save the changes
      4. Open config.php file in your root folder
      5. add "$CFG->fullname = 'forced fullname';" then save the file
      6. Back to settings page
      7. Verify that the fullname has not been overridden to 'forced fullname'
      8. Verify that you can still edit the value
      9. Verify that you you do not see message "Defined in config.php" under the "fullname, shortname, summary and newsitems"
      10. Repeat the same steps for "shortname, summary and newsitems"
      Show
      Note As proposed by Brendan and voted by Jun, the concept of the patch is changed to Maintain the current behaviour but only for the site home settings. Make "fullname, shortname, summary and newsitems" cannot be overriden. Testing the "fullname, shortname, summary and newsitems" Login as admin Go to <wwwroot>/admin/settings.php?section=frontpagesettings Set "Full site name" to "non-forced fullname" then save the changes Open config.php file in your root folder add "$CFG->fullname = 'forced fullname';" then save the file Back to settings page Verify that the fullname has not been overridden to 'forced fullname' Verify that you can still edit the value Verify that you you do not see message "Defined in config.php" under the "fullname, shortname, summary and newsitems" Repeat the same steps for "shortname, summary and newsitems"
    • 6
    • Team Hedgehog Sprint 1.2, Team Hedgehog 2023 Sprint 1.3, Team Hedgehog 2023 Sprint 1.4, Team Hedgehog 2023 Sprint 2.0, Team Hedgehog 2023 Sprint 2.1, Team Hedgehog 2023 Sprint 2.2

    Description

      On the Site administration Front page settings page, the specific settings which are written to the course table and not the config table will incorrectly display an 'Overridden in config.php' when overridden, however they are not displaying the override (in the case of the summary text editor), and they are not respected in the frontpage displayed to users. There is also some weirdness with elements like checkboxes that become disabled, but can be overridden by removing the 'disabled' html attribute and submitting a new value, which will make that value become applied, as the override is ignored.

      As per MDL-28727, the ignored override is intended behaviour, but the settings page display of 'overridden in config.php' is misleading.

      /admin/settings.php?section=frontpagesettings

      To reproduce:

      On frontpage settings, set summary to 'non-forced'.

      In config.php, set $CFG->summary = 'forced';

      Reload frontpage settings, observe 'summary' states overriden, but displays 'non-forced'

       

       

      Attachments

        1. can_manually_remove_disabled_Attribute.png
          can_manually_remove_disabled_Attribute.png
          123 kB
        2. example_of_unsubmitted_form.png
          example_of_unsubmitted_form.png
          58 kB
        3. MDL-75937_step3_1.png
          MDL-75937_step3_1.png
          69 kB
        4. MDL-75937_step3_2.png
          MDL-75937_step3_2.png
          30 kB
        5. MDL-75937_step3_3.png
          MDL-75937_step3_3.png
          115 kB
        6. MDL-75937_step5.png
          MDL-75937_step5.png
          119 kB
        7. MDL-75937_step7~9_1.png
          MDL-75937_step7~9_1.png
          74 kB
        8. MDL-75937_step7~9_2.png
          MDL-75937_step7~9_2.png
          30 kB
        9. test_override_success.png
          test_override_success.png
          49 kB

        Activity

          People

            stevani.andolo@moodle.com Stevani Andolo
            peterburnett Peter Burnett
            David Woloszyn David Woloszyn
            Jun Pataleta Jun Pataleta
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 2 days, 4 hours, 46 minutes
                1w 2d 4h 46m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.