Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.11.11, 4.0.5
Affects Version/s: 3.11.10, 4.0.4
Component/s: Language
Labels:
- ci
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 3.11 Branch:
~~MDL-75970~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-75970-311
Pull 4.0 Branch:
~~MDL-75970~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-75970-400
Pull Main Branch:
~~MDL-75970~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-75970
Testing Instructions:
Hide

Log in as admin

Navigate to Language > Language customisation in site administration

Choose English (en)

Press Open language pack for editing

Under Show strings of these components select access.php and press Show strings

Set Local customisation for the core_access/accesshelp string

Press Save changes to the language pack

From CLI run the following command:

$ php admin/tool/customlang/cli/export.php --lang=en

Confirm you see the following message (note: <TEMPDIR> is whatever value you have for CFG->tempdir):

Starting to export lang files.

== Exporting language en ==

Zip created: <TEMPDIR>/customlang/customlang-export-en.zip

Confirm the zip file is created at that path

From CLI run the following command:

$ php admin/tool/customlang/cli/export.php --lang=en --target=/tmp/local

Confirm you see the following message:

Starting to export lang files.

== Exporting language en ==

Zip created: /tmp/local/customlang-export-en.zip

Confirm the zip file is created at that path

From CLI run the following command:

$ php admin/tool/customlang/cli/export.php --lang=en --target=/tmp/local/

Confirm you see the following message:

Starting to export lang files.

File for en already exists, skipping. If you want to overwrite add the --override=true option.
Show
Log in as admin Navigate to Language > Language customisation in site administration Choose English (en) Press Open language pack for editing Under Show strings of these components select access.php and press Show strings Set Local customisation for the core_access/accesshelp string Press Save changes to the language pack From CLI run the following command: $ php admin/tool/customlang/cli/export.php --lang=en Confirm you see the following message (note: <TEMPDIR> is whatever value you have for CFG->tempdir ): Starting to export lang files. == Exporting language en == Zip created: <TEMPDIR>/customlang/customlang-export-en.zip Confirm the zip file is created at that path From CLI run the following command: $ php admin/tool/customlang/cli/export.php --lang=en --target=/tmp/local Confirm you see the following message: Starting to export lang files. == Exporting language en == Zip created: /tmp/local/customlang-export-en.zip Confirm the zip file is created at that path From CLI run the following command: $ php admin/tool/customlang/cli/export.php --lang=en --target=/tmp/local/ Confirm you see the following message: Starting to export lang files. File for en already exists, skipping. If you want to overwrite add the --override=true option.

Description

Steps to reproduce:

In your Moodle instance, customize some language strings of the english language pack within the language customization GUI.

Open your terminal and run this command:

php admin/tool/customlang/cli/export.php --lang=en --target=/tmp/en_local

Expected result:

In your terminal, you should see this output:

Starting to export lang files.

== Exporting language en ==

Zip created: /tmp/en_local.zip

There should be a zip file at /tmp/en_local.zip

Actual result:

In your terminal, you see this output:

Starting to export lang files.

== Exporting language en ==

Zip created: /tmp/en_local[[exportzipfilename]]

There is a zip file at /tmp/en_local[[exportzipfilename]]

Analysis:

The filename for the zip file is composed at https://github.com/moodle/moodle/blame/master/admin/tool/customlang/cli/export.php#L90

This line contains a call to

get_string('exportzipfilename', 'tool_customlang', ['lang' => $lang])

The string with the identifier 'exportzipfilename' should most probably contain the zip file suffix. However, there isn't a string with the 'exportzipfilename' identifier in the language pack.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-75970_master_1.png
14/Oct/22 11:27 AM
56 kB
Angelia Dela Cruz
MDL-75970_master_2.png
14/Oct/22 11:27 AM
37 kB
Angelia Dela Cruz
MDL-75970_master_3.png
14/Oct/22 11:27 AM
24 kB
Angelia Dela Cruz
MDL-75970_v311_1.png
14/Oct/22 11:27 AM
49 kB
Angelia Dela Cruz
MDL-75970_v311_2.png
14/Oct/22 11:27 AM
37 kB
Angelia Dela Cruz
MDL-75970_v311_3.png
14/Oct/22 11:27 AM
25 kB
Angelia Dela Cruz
MDL-75970_v400_1.png
14/Oct/22 11:27 AM
59 kB
Angelia Dela Cruz
MDL-75970_v400_2.png
14/Oct/22 11:27 AM
41 kB
Angelia Dela Cruz
MDL-75970_v400_3.png
14/Oct/22 11:27 AM
25 kB
Angelia Dela Cruz

Issue Links

blocks

MDL-75972 tool_customlang CLI export leaves empty directory

Closed

has a non-specific relationship to

MDL-69582 Add export to tool_customlang

Closed

has been marked as being related by

MDL-76222 tool_customlang CLI export unneeded language string

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Alexander Bias

Peer reviewer:: Alexander Bias

Integrator:: Ilya Tregubov

Tester:: Angelia Dela Cruz

Participants:: Alexander Bias, Angelia Dela Cruz, CiBoT, Helen Foster, Ilya Tregubov, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 12/Oct/22 2:18 PM

Updated:: 07/Nov/22 10:24 PM

Resolved:: 14/Oct/22 8:36 PM

Fix Release Date:: 14/Nov/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

45m