Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76012

"Invalid URL" validation in TinyMCE H5P plugin not working

    XMLWordPrintable

Details

    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • MDL-76012-master
    • Hide

      Initial setup

      1. Enable the TinyMCE editor on the Administration page.
      2. Change the Editor preferences to TinyMCE editor.

      Behat test

      1. Copy the attached h5p.feature file into lib/editor/tiny/plugins/h5p/tests/behat/.
      2. Init the Behat test
      3. Run the Behat test with that feature file
      4. Verify that all the steps inside that file are passed.

      Manual test

      1. Login as admin.
      2. Open the profile page.
      3. Click Edit Profile.
      4. Click on Configure H5P content button in the Tiny toolbar.
      5. Fill the H5P URL or file upload text field with this value: ftp://moodle.h5p.com/content/1290772960722742119
      6. Click on the Insert H5P content button.
      7. Verify that you will see an Invalid URL warning.

       

      Show
      Initial setup Enable the TinyMCE editor on the Administration page. Change the Editor preferences to TinyMCE editor. Behat test Copy the attached h5p.feature file into lib/editor/tiny/plugins/h5p/tests/behat/. Init the Behat test Run the Behat test with that feature file Verify that all the steps inside that file are passed. Manual test Login as admin. Open the profile page. Click Edit Profile. Click on Configure H5P content button in the Tiny toolbar. Fill the H5P URL or file upload text field with this value: ftp://moodle.h5p.com/content/1290772960722742119 Click on the Insert H5P content button. Verify that you will see an Invalid URL warning.  
    • 2
    • Team Hedgehog Sprint 1.1

    Description

      Detected while working on Behat tests for Tiny MDL-75982

      When trying to insert a invalid h5p URL a validation message "Invalid URL" should be displayed similarly to atto editor. Currently, the invalid URL is inserted to the editor content.

      As acceptance criteria, this commit should be added to the patch, which contains a behat test to be added to lib/editor/tiny/plugins/h5p/tests/behat/h5p.feature and that test must pass.

      Attachments

        Issue Links

          Activity

            People

              huongn@moodle.com Huong Nguyen
              lameze Simey Lameze
              Stevani Andolo Stevani Andolo
              Jun Pataleta Jun Pataleta
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 2 minutes
                  7h 2m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.