Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76016

Bump to Goutte driver 2 / Goutte 4

    XMLWordPrintable

Details

    Description

      Right now we are using the Goutte driver 1.x that uses old Goutte client.

      And we were holding on this PR in Mink to be able to bump:

      https://github.com/FriendsOfBehat/MinkExtension/pull/16

      It has been merged hours ago, and they have released v2.7.2:

      https://github.com/FriendsOfBehat/MinkExtension/releases/tag/v2.7.2

      So, this issue is about to update our dependencies to use that mink extension and the newer goutte versions.


      Off topic, note that, as an alternative to bump to Goutte 4, we were planning to switch to BrowserKit client, that is better supported (apparently) and, more yet, the current Goutte client, is a thin-wrapper over BrowserKit. So 100% the same codebase is used (in fact, when Goutte 4 is installed, all the BrowserKit components are installed too, heh).

      So, looking to the BrowserKit alternative, I ended with this super-simple patch that allowed us to make the switch (and all tests were passing perfectly @ Cis). I leave it here for future reference when BrowserKit or HttpClient are searched / considered:

      https://github.com/stronk7/moodle/compare/master...bump_goutte_driver_20

      Given the times (freeze, release...) we have decided to stay with Goutte client a bit longer.


      Ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Paul Holden Paul Holden
              Victor Déniz Falcón Victor Déniz Falcón
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 26 minutes
                  1h 26m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.