Loading...

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Pull from Repository:
https://github.com/ilyatregubov/moodle.git
Pull Main Branch:
~~MDL-76033~~-master
Pull Main Diff URL:
https://github.com/ilyatregubov/moodle/compare/f8d28e4ca6...MDL-76033-master
Testing Instructions:
Hide

Install a fresh Moodle site using Moodle 3.11

Create a course using default settings

View the course page and copy the url to clipboard so you can go back there

Upgrade the code to Moodle 4.0 (just code - don't run upgrade script)

Visit the course page directly

EXPECTED: You should not see a coding exception error at this point, but should be redirect to the upgrade process as normal.

BEFORE FIX: A coding exception appears.

Same instructions for my/indexsys.php page
Show
Install a fresh Moodle site using Moodle 3.11 Create a course using default settings View the course page and copy the url to clipboard so you can go back there Upgrade the code to Moodle 4.0 (just code - don't run upgrade script) Visit the course page directly EXPECTED : You should not see a coding exception error at this point, but should be redirect to the upgrade process as normal. BEFORE FIX : A coding exception appears. Same instructions for my/indexsys.php page

After landing ~~MDL-58266~~ if you update Moodle to use latest code and access course page without running upgrade you will get

Debug info: ERROR: relation "mdl_course_modules_viewed" does not exist

LINE 6: ... LEFT JOIN mdl_course...

SELECT cm.id AS cmid, cmc.*,

CASE WHEN cmv.id IS NULL THEN 0 ELSE 1 END AS viewed

FROM mdl_course_modules cm

LEFT JOIN mdl_course_modules_completion cmc

ON cmc.coursemoduleid = cm.id AND cmc.userid = $1

LEFT JOIN mdl_course_modules_viewed cmv

ON cmv.coursemoduleid = cm.id AND cmv.userid = $2

INNER JOIN mdl_modules m ON m.id = cm.module

WHERE m.visible = 1 AND cm.course = $3

[array (

0 => 2,

1 => 2,

2 => '13',

)]

Error code: dmlreadexception

We should force site upgrade to create a table

is a regression caused by

MDL-58266 "Student must view this activity to complete it" should be written to database

Participants:: Angelia Dela Cruz, CiBoT, Eloy Lafuente (stronk7), Ilya Tregubov, Victor Déniz Falcón

Estimated:

Not Specified

Remaining:

Logged:

1h 25m