Review which parts of MDL-73270 need to be reverted for 4.1

Prerequisites

1. Ability to install different Moodle versions and plugins (git).
2. Ability to edit (hack) one file for easier testing.

A) Before the patch: MNet

1. Install master branch from moodle.git
2. Install the webservice_xmlrpc plugin

   git clone https://github.com/moodlehq/moodle-webservice_xmlrpc.git webservice/xmlrpc

3. Visit admin/index.php to get the plugin installed.
4. Go to Admin -> General -> Advanced features
5. Enable "Networking" (On).
6. Enable "Portfolios" (tick).
7. Save changes.
8. Go to Admin -> Networking -> and visit all the links there:
   1. Settings
   2. Manage peers
   3. SSO access control
   4. Remote enrolment client
   5. XML-RPC hosts
   6. Profile fields
   7. All hosts
9. Verify that in all the links above you see a "It has been detected that the Moodle Networking is enabled on your site" notification.
10. Go to Admin -> Plugins -> Manage authentication
11. Enable the "MNet authentication"
12. Verify that you see a "It has been detected that the MNet authentication is enabled on your site" notification.
13. To save us from some heavy configuration, apply these changes to the portfolio/mahara/lib.php file:

    diff --git a/portfolio/mahara/lib.php b/portfolio/mahara/lib.php

    index ee725bd2c07..64907fbd3ad 100644

    --- a/portfolio/mahara/lib.php

    +++ b/portfolio/mahara/lib.php

    @@ -91,13 +91,13 @@ class portfolio_plugin_mahara extends portfolio_plugin_pull_base {

    $hosts[$host->id] = $host->name;

    }

    $mform->addElement('select', 'mnethostid', get_string('mnethost', 'portfolio_mahara'), $hosts);

    - $mform->addRule('mnethostid', $strrequired, 'required', null, 'client');

    $mform->setType('mnethostid', PARAM_INT);

    $mform->addElement('selectyesno', 'enableleap2a', get_string('enableleap2a', 'portfolio_mahara'));

    $mform->setType('enableleap2a', PARAM_BOOL);

    }

    public function instance_sanity_check() {

    + return 0;

    // make sure the host record exists since we don't have referential integrity

    if (!is_enabled_auth('mnet')) {

    return PORTFOLIO_MAHARA_ERR_NOMNETAUTH;

    @@ -117,6 +117,7 @@ class portfolio_plugin_mahara extends portfolio_plugin_pull_base {

    }

    public static function plugin_sanity_check() {

    + return 0;

    global $CFG, $DB;

    $errorcode = 0;

    if (!isset($CFG->mnet_dispatcher_mode) || $CFG->mnet_dispatcher_mode != 'strict') {

14. Go to Admin -> Plugins -> Manage portfolios
15. "Enable and visible" the "Mahara ePortfolio".
16. In the form that appears, "Save" changes.
17. Verify that the "Mahara ePortfolio" is now "Enabled and visible".
18. Go to "admin/index.php"
19. You may be redirected to a page with some profile field settings, just "Save" it without modifying anything.
20. Verify that now you're in the admin notifications page.
21. Verify that you see a "It has been detected that the Mahara ePortfolio is enabled on your site" notification.
22. Go to Admin -> Server -> Environment
23. *Verify" that you see a "4.1 upwards" version.
24. Verify that you see a "It has been detected that the Mahara ePortfolio is enabled on your site" notification.

B) Before the patch: XML-RPC WS

1. Continue with the same site than in previous test.
2. Go to Admin -> Server -> Web services -> Overview
3. Click on "Enable web services" and enable them. Save changes.
4. Go to Admin -> Server -> Web services -> Overview again.
5. Verify that "Enable web services" shows a "Yes" status.
6. Click on "Enable protocols" and enable the REST protocol.
7. Now, enable the "XML-RPC protocol and verify that you see a "It has been detected that the XML-RPC Web Service protocol is enabled on your site" notification.
8. Go to Admin -> Server -> Environment
9. *Verify" that you see a "4.1 upwards" version.
10. Verify that you see a "It has been detected that the XML-RPC Web Service protocol is enabled on your site" notification.

C) After the patch: MNet

1. Upgrade the site to the master branch from integration.git
2. Go to Admin -> Networking -> and visit all the links there:
   1. Settings
   2. Manage peers
   3. SSO access control
   4. Remote enrolment client
   5. XML-RPC hosts
   6. Profile fields
   7. All hosts
3. Verify that none of them show a "It has been detected that the Moodle Networking is enabled on your site" notification.
4. Go to Admin -> Plugins -> Manage authentication
5. Verify that "MNet authentication" is enabled (from previous tests).
6. Verify that you don't see a "It has been detected that the MNet authentication is enabled on your site" notification.

D) After the patch: XML-RPC WS

1. Continue with the same site than in previous test.
2. Go to Admin -> Server -> Environment
3. Verify that you see a "4.1 upwards" version.
4. Verify that you see a "It has been detected that the XML-RPC Web Service protocol is enabled on your site" notification.
5. Go to "admin/index.php".
6. Verify that you see a "It has been detected that the XML-RPC Web Service protocol is enabled on your site" notification.
7. Go to Admin -> Server -> Web services -> Overview
8. Verify that the "XML-RPC protocol" is enabled.
9. Verify that you see a "It has been detected that the XML-RPC Web Service protocol is enabled on your site" notification.
10. Disable the "XML-RPC protocol".
11. Verify that the notification is gone.
12. Go to Admin -> Server -> Environment
13. Verify that you see a "4.1 upwards" version.
14. Verify that you don't see any XML-RPC notification.
15. Go to "admin/index.php".
16. Verify that you don't see any XML-RPC notification.