Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76054

Remove the xmlrpc extension recommendation in environmental checks

XMLWordPrintable

    • MOODLE_401_STABLE
    • MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Hide

      0 - Prerequisites

      1. Ensure that there is NOT any $CFG->moodledata/environment directory in your installation. If it exists... it contains old environment info. Remove the directory completely before continuing with the tests below.
      2. Ensure that the php-xmlrpc extension is not enabled in you php/webserver. Depending of your OS you will need to disable / remove it in different ways.

      A - On Master, 400, 311 and 39 (all supported and security supported branches):

      1. Install a site from integration.git with that branch.
      2. Verify that the xmlrpc warning is shown (and warns, because the xmlrpc extension has been disabled by the prerequisites) when installing stables (39, 311, 400) but not master (4.1dev).
      3. Continue with the installation.
      4. Go to admin -> server -> environment
      5. One "4.1 upwards" Moodle version should be available.
      6. Verify that no "xmlrpc" check/recommendation is shown.
      7. If there are other (older than 4.1) versions available in the dropdown... select them.
      8. Verify that the "xmlrpc" check/recommendation is shown with message 'The XMLRPC extension is useful for web services and Moodle networking.'

      ^^^ Basically, verify that environment checks for versions < 4.1 continue showing the xmlrpc warning in all the branches, and that versions = 4.1 and up does not have the warning anymore.

      B - Verify, for all the numeric (XYZ) branches above, that the environment.xml file is 100% the same (requires git or diff use). All the commands should return NO differences (nothing should be output):

      Note: It's enough to test on one instance only (e.g. on a master instance)

      1. git diff MOODLE_XYZ_STABLE master admin/environment.xml
      Show
      0 - Prerequisites Ensure that there is NOT any $CFG->moodledata/environment directory in your installation. If it exists... it contains old environment info. Remove the directory completely before continuing with the tests below. Ensure that the php-xmlrpc extension is not enabled in you php/webserver. Depending of your OS you will need to disable / remove it in different ways. A - On Master, 400, 311 and 39 (all supported and security supported branches): Install a site from integration.git with that branch. Verify that the xmlrpc warning is shown (and warns, because the xmlrpc extension has been disabled by the prerequisites) when installing stables (39, 311, 400) but not master (4.1dev). Continue with the installation. Go to admin -> server -> environment One "4.1 upwards" Moodle version should be available. Verify that no "xmlrpc" check/recommendation is shown. If there are other (older than 4.1) versions available in the dropdown... select them. Verify that the "xmlrpc" check/recommendation is shown with message 'The XMLRPC extension is useful for web services and Moodle networking.' ^^^ Basically, verify that environment checks for versions < 4.1 continue showing the xmlrpc warning in all the branches, and that versions = 4.1 and up does not have the warning anymore. B - Verify, for all the numeric (XYZ) branches above, that the environment.xml file is 100% the same (requires git or diff use). All the commands should return NO differences (nothing should be output): Note: It's enough to test on one instance only (e.g. on a master instance) git diff MOODLE_XYZ_STABLE master admin/environment.xml

      With the replacement of the extension by php library happening @ MDL-70889 and the removal of the webservice_xmlrpc, core doesn't need the xmlrpc extension anymore.

      • Remove the requirement from environment.xml (all supported branches) for 4.1 and up.
      • Remove the recommendation from composer.

        1. MDL-76054_master_test a_1.png
          MDL-76054_master_test a_1.png
          162 kB
        2. MDL-76054_master_test a_2.png
          MDL-76054_master_test a_2.png
          154 kB
        3. MDL-76054_test b.png
          MDL-76054_test b.png
          87 kB
        4. MDL-76054_v311_test a_1.png
          MDL-76054_v311_test a_1.png
          153 kB
        5. MDL-76054_v311_test a_2.png
          MDL-76054_v311_test a_2.png
          160 kB
        6. MDL-76054_v311_test a_3.png
          MDL-76054_v311_test a_3.png
          153 kB
        7. MDL-76054_v311_test a_4.png
          MDL-76054_v311_test a_4.png
          152 kB
        8. MDL-76054_v39_test a_1.png
          MDL-76054_v39_test a_1.png
          148 kB
        9. MDL-76054_v39_test a_2.png
          MDL-76054_v39_test a_2.png
          151 kB
        10. MDL-76054_v39_test a_3.png
          MDL-76054_v39_test a_3.png
          149 kB
        11. MDL-76054_v39_test a_4.png
          MDL-76054_v39_test a_4.png
          149 kB
        12. MDL-76054_v39_test a_5.png
          MDL-76054_v39_test a_5.png
          149 kB
        13. MDL-76054_v39_test a_6.png
          MDL-76054_v39_test a_6.png
          147 kB
        14. MDL-76054_v400_test a_1.png
          MDL-76054_v400_test a_1.png
          160 kB
        15. MDL-76054_v400_test a_2.png
          MDL-76054_v400_test a_2.png
          153 kB
        16. MDL-76054_v400_test a_3.png
          MDL-76054_v400_test a_3.png
          153 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Meirza Meirza
            Jun Pataleta Jun Pataleta
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours
                6h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.