[MDL-76059] Console errors on login page when guest login disabled - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.10, 4.0.4
Fix Version/s: 3.11.11, 4.0.5
Component/s: Forms Library
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-76059~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-76059-311
Pull 4.0 Branch:
~~MDL-76059~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-76059-400
Pull Master Branch:
~~MDL-76059~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-76059
Testing Instructions:
Hide

Open browser developer console

Log in as admin

Navigate to Plugins > Authentication > Manage authentication from site administration

Set Guest login button to Hide and save changes

Log out

Press Log in (if not already on the log in screen)

Confirm there are no errors in browser console
Show
Open browser developer console Log in as admin Navigate to Plugins > Authentication > Manage authentication from site administration Set Guest login button to Hide and save changes Log out Press Log in (if not already on the log in screen) Confirm there are no errors in browser console

Description

This is a regression from ~~MDL-75083~~, which mistakenly assumes the "loginguestbtn" element always exists (it's presence is dependent on template context data)

Leads to the following on the console of the login page:

Uncaught TypeError: button is null

    init events.js:35401

    <anonymous> index.php:237

    execCb require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    init require.min.js:5

    o require.min.js:5

    setTimeout handler*req.nextTick< require.min.js:5

    o require.min.js:5

    requirejs require.min.js:5

    <anonymous> index.php:235

    execCb require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    bind require.min.js:5

    emit require.min.js:5

    each require.min.js:5

    emit require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    bind require.min.js:5

    emit require.min.js:5

    each require.min.js:5

    emit require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    init require.min.js:5

    h require.min.js:5

    completeLoad require.min.js:5

    onScriptLoad require.min.js:5

    load require.min.js:5

    load require.min.js:5

    load require.min.js:5

    fetch require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    enable require.min.js:5

    enable require.min.js:5

    bind require.min.js:5

    each require.min.js:5

    enable require.min.js:5

    init require.min.js:5

    h require.min.js:5

    completeLoad require.min.js:5

    onScriptLoad require.min.js:5

    load require.min.js:5

    load require.min.js:5

    load require.min.js:5

    fetch require.min.js:5

    check require.min.js:5

    enable require.min.js:5

    enable require.min.js:5

    enable require.min.js:5

    bind require.min.js:5

    each require.min.js:5

    enable require.min.js:5

    init require.min.js:5

    o require.min.js:5

    setTimeout handler*req.nextTick< require.min.js:5

    o require.min.js:5

    requirejs require.min.js:5

    <anonymous> index.php:173

events.js:formatted:35401

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-76059_master.png
228 kB
10/Nov/22 1:21 PM
MDL-76059_v311.png
78 kB
10/Nov/22 1:21 PM
MDL-76059_v400.png
227 kB
10/Nov/22 1:21 PM

Issue Links

Discovered while testing

MDL-75848 "Cannot read properties of null" error when using Atto editor

Closed

is a regression caused by

MDL-75083 Login form double submission leads to invalid login

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Raquel Ortega

Integrator:: Huong Nguyen

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Huong Nguyen, Paul Holden, Raquel Ortega, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 22/Oct/22 2:02 AM

Updated:: 11/Nov/22 11:12 PM

Resolved:: 11/Nov/22 11:12 PM

Fix Release Date:: 14/Nov/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 25m