Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76059

Console errors on login page when guest login disabled

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • Hide
      1. Open browser developer console
      2. Log in as admin
      3. Navigate to Plugins > Authentication > Manage authentication from site administration
      4. Set Guest login button to Hide and save changes
      5. Log out
      6. Press Log in (if not already on the log in screen)
      7. Confirm there are no errors in browser console
      Show
      Open browser developer console Log in as admin Navigate to Plugins > Authentication > Manage authentication from site administration Set Guest login button to Hide and save changes Log out Press Log in (if not already on the log in screen) Confirm there are no errors in browser console

    Description

      This is a regression from MDL-75083, which mistakenly assumes the "loginguestbtn" element always exists (it's presence is dependent on template context data)

      Leads to the following on the console of the login page:

      Uncaught TypeError: button is null
          init events.js:35401
          <anonymous> index.php:237
          execCb require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          init require.min.js:5
          o require.min.js:5
          setTimeout handler*req.nextTick< require.min.js:5
          o require.min.js:5
          requirejs require.min.js:5
          <anonymous> index.php:235
          execCb require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          bind require.min.js:5
          emit require.min.js:5
          each require.min.js:5
          emit require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          bind require.min.js:5
          emit require.min.js:5
          each require.min.js:5
          emit require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          init require.min.js:5
          h require.min.js:5
          completeLoad require.min.js:5
          onScriptLoad require.min.js:5
          load require.min.js:5
          load require.min.js:5
          load require.min.js:5
          fetch require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          enable require.min.js:5
          enable require.min.js:5
          bind require.min.js:5
          each require.min.js:5
          enable require.min.js:5
          init require.min.js:5
          h require.min.js:5
          completeLoad require.min.js:5
          onScriptLoad require.min.js:5
          load require.min.js:5
          load require.min.js:5
          load require.min.js:5
          fetch require.min.js:5
          check require.min.js:5
          enable require.min.js:5
          enable require.min.js:5
          enable require.min.js:5
          bind require.min.js:5
          each require.min.js:5
          enable require.min.js:5
          init require.min.js:5
          o require.min.js:5
          setTimeout handler*req.nextTick< require.min.js:5
          o require.min.js:5
          requirejs require.min.js:5
          <anonymous> index.php:173
      events.js:formatted:35401
      
      

      Attachments

        1. MDL-76059_master.png
          MDL-76059_master.png
          228 kB
        2. MDL-76059_v311.png
          MDL-76059_v311.png
          78 kB
        3. MDL-76059_v400.png
          MDL-76059_v400.png
          227 kB

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Raquel Ortega Raquel Ortega
              Huong Nguyen Huong Nguyen
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.