[MDL-76061] Calendar event type cannot be changed from type "user" - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.10, 4.0.4, 4.0.5, 4.1
Fix Version/s: 4.0.6, 4.1.1
Component/s: Calendar
Labels:
- ci
- mebis
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/PhMemmel/moodle
Pull 3.11 Branch:
~~MDL-76061~~-MOODLE_311_STABLE
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...PhMemmel:moodle:MDL-76061-MOODLE_311_STABLE
Pull 4.0 Branch:
~~MDL-76061~~-MOODLE_400_STABLE
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...PhMemmel:moodle:MDL-76061-MOODLE_400_STABLE
Pull 4.1 Branch:
~~MDL-76061~~-MOODLE_401_STABLE
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...PhMemmel:moodle:MDL-76061-MOODLE_401_STABLE
Pull Master Branch:
~~MDL-76061~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...PhMemmel:moodle:MDL-76061-master
Testing Instructions:
Hide

Log in as teacher with at least one course enroled as teacher (so you have the capability `moodle/calendar:manageevents`)

Go to the calendar

Create a calendar event of type "user" and save

Edit the created event, change its type to "course", select a course from the list, save.

Without patch: Ensure you are seeing the error message posted in this issue

With patch: Ensure the event type has been properly changed to an event of the selected course

Repeat for the following cases:

user -> course

user -> group

user -> category
Show
Log in as teacher with at least one course enroled as teacher (so you have the capability `moodle/calendar:manageevents`) Go to the calendar Create a calendar event of type "user" and save Edit the created event, change its type to "course", select a course from the list, save. Without patch: Ensure you are seeing the error message posted in this issue With patch: Ensure the event type has been properly changed to an event of the selected course Repeat for the following cases: user -> course user -> group user -> category

Description

A calendar event of type "user" cannot be changed to type "course". An error is being shown with the following stack trace:

Error code: nopermissiontoupdatecalendar

* line 597 of /calendar/lib.php: moodle_exception thrown

* line 940 of /calendar/externallib.php: call to calendar_event->update()

* line ? of unknownfile: call to core_calendar_external::submit_create_update_form()

* line 261 of /lib/externallib.php: call to call_user_func_array()

* line 81 of /lib/ajax/service.php: call to external_api::call_external_function()

Probably also affects moodle versions 3.11 and below, but I do not have an instance to test right now.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

400_nopatch.gif
421 kB
11/Jan/23 3:18 PM
400.gif
454 kB
11/Jan/23 3:18 PM
401_nopatch.gif
466 kB
11/Jan/23 3:18 PM
401.gif
458 kB
11/Jan/23 3:18 PM
master_nopacth.gif
381 kB
11/Jan/23 3:18 PM
master.gif
564 kB
11/Jan/23 3:18 PM
screenshot-1.png
42 kB
23/Oct/22 2:58 AM

Issue Links

has a non-specific relationship to

MDL-62959 Changing a course event to a user event results in an error

Closed

Activity

People

Assignee:: PhMemmel

Reporter:: PhMemmel

Peer reviewer:: Meirza

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Eloy Lafuente (stronk7), Huong Nguyen, Jake Dallimore, Jun Pataleta, Luca Bösch, Meirza, PhMemmel, Ron Carl Alfon Yu

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 5 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 23/Oct/22 2:57 AM

Updated:: 13/Jan/23 5:32 PM

Resolved:: 13/Jan/23 11:58 AM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Remaining:

Logged:

2d 1h 2m